Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Refactor ImportAccountView.js and LoginView.js files #11694

Merged

Conversation

SamuelSalas
Copy link
Member

@SamuelSalas SamuelSalas commented Oct 8, 2024

Description

We are aiming to refactor the page objects in the modal folder so that they strictly follow the page object model pattern. This would aide in providing more readable and help standardize the way we create our tests. Because of the amount of files remaining, this issue will focus on working on three files to refactor, as well as their respective testIDS.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Regression Test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/565bdc5f-1994-4751-9bbe-5681ebd83ea7

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas added Run Smoke E2E Triggers smoke e2e on Bitrise Detox labels Oct 8, 2024
@SamuelSalas SamuelSalas self-assigned this Oct 8, 2024
@SamuelSalas SamuelSalas requested review from a team as code owners October 8, 2024 23:51
Copy link
Contributor

github-actions bot commented Oct 8, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 440324a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d55b0801-56a2-4ec9-ac77-8f3121155877

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 9, 2024

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅ ✅

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!✅

@SamuelSalas SamuelSalas added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit d28d3f3 Oct 9, 2024
37 checks passed
@SamuelSalas SamuelSalas deleted the test/1857-refactor-importaccountview-loginviewjs-pom branch October 9, 2024 20:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants