Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1653 first feature flag poc #11578

Merged
merged 14 commits into from
Oct 7, 2024
Merged

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Oct 2, 2024

Description

  • This is the actual first implementation of the LaunchDarkly API for feature flags
  • This utilizes the mobileMinimumVersions.appMinimumBuild feature flag in LaunchDarkly

Related issues

Fixes: #1653

This PR builds upon work in previous LD setup work: #10294

Manual testing steps

  1. Start the app
  2. in app/components/hooks/MinimumVersions/useMinimumVersions.tsx
  • Change line: 22 featureFlags?.mobileMinimumVersions?.appMinimumBuild > currentBuildNumber;
    to: featureFlags?.mobileMinimumVersions?.appMinimumBuild > 0;
  1. Restart app & enter password
  2. Modal should popup prompting user to update app version

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-03.at.15.12.17.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@frankvonhoven frankvonhoven marked this pull request as ready for review October 3, 2024 20:19
@frankvonhoven frankvonhoven requested review from a team as code owners October 3, 2024 20:19
@frankvonhoven frankvonhoven added Run Smoke E2E Triggers smoke e2e on Bitrise needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 70c9251
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b07260f5-e3e3-4f03-86c4-e493290719ad

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need tests!

@frankvonhoven frankvonhoven added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0099fc0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/022623a7-bb67-40d9-9ec1-741c41f4e4fa

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify test name so they are easy to understand the use case. People hardly think in reverse.
Direct positive sentences are easier even if implementation requires an expect.not.to...

tommasini
tommasini previously approved these changes Oct 7, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Aggree with Nico comments! let me know when resolved and I will approve it again

Copy link

sonarcloud bot commented Oct 7, 2024

@frankvonhoven frankvonhoven added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5dd76e9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/747b0085-d0ea-4d1a-a299-4255c777dcb7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@frankvonhoven frankvonhoven added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 2a8c665 Oct 7, 2024
42 of 43 checks passed
@frankvonhoven frankvonhoven deleted the feat/1653-first-feature-flag-poc branch October 7, 2024 21:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants