Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade assets-controllers to v31 #11412

Merged
merged 26 commits into from
Oct 8, 2024
Merged

fix: upgrade assets-controllers to v31 #11412

merged 26 commits into from
Oct 8, 2024
+1,824 −1,284

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Sep 24, 2024 •
edited
Loading

Description

PR to upgrade assets-controllers to v31.0.0

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Verifying NFT and Token detection:

Screen.Recording.2024-10-01.at.17.28.11.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri force-pushed the feat/upgrade-assets-controllers-to-v31 branch from 276e2a3 to afc3a92 Compare September 26, 2024 10:52
@socket-security Socket Security
Copy link

socket-security bot commented Sep 26, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 1.54 MB metamaskbot
npm/@metamask/[email protected] None 0 123 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 26, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@sahar-fehri sahar-fehri force-pushed the feat/upgrade-assets-controllers-to-v31 branch from 7c9494e to f27652f Compare September 26, 2024 13:40
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 26, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 26, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@sahar-fehri sahar-fehri marked this pull request as ready for review September 26, 2024 15:31
@sahar-fehri sahar-fehri requested review from a team as code owners September 26, 2024 15:31
tommasini
tommasini reviewed Oct 1, 2024
View reviewed changes
app/core/Engine.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9d30780
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e1a48e3d-1098-42c2-9727-ea8010865c0e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

gambinish
gambinish previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approving, but I think that we should sync up as a team before we get this merged 👍

tommasini
tommasini previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment on the test file!

app/store/migrations/054.test.ts Outdated Show resolved Hide resolved
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bd7dcd4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c341864-e19e-496d-9dcd-b4a09c626194

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 8, 2024
cryptodev-2s
cryptodev-2s approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0622ce9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9e28942-4aa4-4d92-a6e6-2e87b273ac47

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 8, 2024
@sahar-fehri sahar-fehri removed this pull request from the merge queue due to a manual request Oct 8, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 368fc19 Oct 8, 2024
43 checks passed
@sahar-fehri sahar-fehri deleted the feat/upgrade-assets-controllers-to-v31 branch October 8, 2024 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@salimtb salimtb salimtb approved these changes

@gambinish gambinish gambinish approved these changes

@tommasini tommasini tommasini approved these changes

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sahar-fehri @tommasini @salimtb @gambinish @cryptodev-2s @gauthierpetetin @legobeat