Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3299): add tracking to network switching and confirmation #11386

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Sep 23, 2024

Description

Adds tracking to the user requesting network switching as well as his press of the confirmation button.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3299

Manual testing steps

  1. Go to the in app browser and open have a connected dapp for example to ethereum main net
  2. In the dapp select to change network, the modal will come up, thats when the tracking event if fire for user requesting a network change
  3. Confirm the network change by pressing the button, this corresponds to the confirm pressed tracked event

Screenshots/Recordings

Mixpanel logs for the two events

Mixpanel logs for the two events

Network Switch Requested and Modal Shown

Interaction Tracked event
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Network Switch Confirm Pressed

Interaction Tracked event
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Sep 23, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 24, 2024
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 770fd8a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b484810e-c93a-45b6-8874-3c25ab3c5e2a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 marked this pull request as ready for review September 25, 2024 16:55
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner September 25, 2024 16:55
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

sonarcloud bot commented Sep 25, 2024

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit a616742 Sep 25, 2024
36 checks passed
@EtherWizard33 EtherWizard33 deleted the feat-3299-track-the-network-swithcing-request-and-confirmation branch September 25, 2024 19:52
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 25, 2024
@EtherWizard33
Copy link
Contributor Author

Also validated on the release 7.33 build 1446 on testflight, including image as reference
Screenshot 2024-10-07 at 9 05 55 AM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants