Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NOTIFY-1096): add account syncing #11190
base: main
Are you sure you want to change the base?
feat(NOTIFY-1096): add account syncing #11190
Changes from all commits
631dbe9
04780e0
771ad50
2f20cdb
249a1ba
6e2b5b5
888f01d
b9bb37a
6c9b2ce
80af81c
ab17435
95563d9
c8e8e91
c3a3cb6
c0be57e
9aca646
8efc079
8836b0f
970f65e
63708ef
b6d891e
c821134
5d17b5d
b7af253
91fa607
01d2304
a3fc2cc
a971856
fd5615d
cdca605
92d9839
40e8294
c157056
5d708da
77c9c31
0210192
2be206f
f5a2aa9
1050e86
66aff4c
22cfc1a
bcfd1bb
307b449
7a4dc64
b03fd6a
ddf4c9e
2fee02f
0fa03b7
730fb38
c953e4f
1ba5618
5752f14
d859175
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Can we test this effect in the unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pain to locally test using jest for
app/components/Views/Wallet/index.test.tsx
, do you have a trick in mind so I can bypass this error?Happy to explore that for both
listNotifications
anddispatchAccountSyncing
in a subsequent PR as well. LMKThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C: trackEvent called with legacy way has been deprecated recently. You will find out how to use the new
MetricsEventBuilder
in the code documentation