fix: Reuse mmkv instance once created

[tommasini]

Description

We should reuse MMKV instance instead of creating a new one each time we want to access storage.

Related issues

N/A

Manual testing steps

1. Fresh install the app
2. Press import with SRP
3. Accept share data and terms of use
4. kill the app
5. Open it
6. go to import with SRP again
7. Should not show the same modals (This means it's being saved and read under MMKV)

Screenshots/Recordings

Screen.Recording.2024-10-09.at.11.12.46.mov

Before

N/A

After

N/A

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8731e04
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c669e910-54b5-4466-88b8-e31c53c1d016

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0ad4386
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/de487618-9e7e-4132-9d3c-1b35f2f41ca2

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.17%. Comparing base (9e3d268) to head (a322f83).

Files with missing lines	Patch %	Lines
app/store/storage-wrapper.ts	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11139      +/-   ##
==========================================
+ Coverage   54.14%   54.17%   +0.03%     
==========================================
  Files        1695     1695              
  Lines       38592    38596       +4     
  Branches     4718     4725       +7     
==========================================
+ Hits        20894    20908      +14     
+ Misses      16260    16247      -13     
- Partials     1438     1441       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a322f83
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ae660838-4203-4d57-ba18-793565ae00d9

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bb004c6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/33fd2cf3-2488-43bf-854d-0bfd2b953855

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request