Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: custom rpc network #1060

Merged
merged 8 commits into from
Sep 9, 2019
Merged

Bugfix: custom rpc network #1060

merged 8 commits into from
Sep 9, 2019

Conversation

estebanmino
Copy link
Contributor

Description

This PR

  • Fixes txs from dapps using custom rpc networks
  • Uses ticker on transaction review instead of ETH symbol, in order to display custom network ticker.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #903
Resolves #1052

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 5, 2019
brunobar79
brunobar79 reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 100

brunobar79
brunobar79 approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yourihua
Copy link

yourihua commented Sep 6, 2019

if i change network to custom RPC networks, switch account view not use ticker, it's ETH.

@ibrahimtaveras00
Copy link
Contributor

Issue 1:

When I'm on mainnet and go to https://dai-bridge.poa.network/ to transfer DAI to xDai I see this on confirm transaction view

image

Issue 2:

When I'm on xDAI custom network, then go to xdai.io and send xDAI to another account I don't see fiat amount

image

Also, if I don't have a symbol set on xDAI network I see this:

image

ibrahimtaveras00
ibrahimtaveras00 approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixes look good, QA Passed 👍

@estebanmino estebanmino merged commit 947650f into develop Sep 9, 2019
estebanmino added a commit that referenced this pull request Oct 4, 2019
@estebanmino
Version 0.2.5 (#1138)
25a6242 
* More UIWebview cleanup (#1045)

* update postinstall

* fix unit tests

* Migrate to yarn (#1049)

* migrate to yarn

* fix lint and warnings

* update readme instructions

* fix unit tests

* bugfix: token transfer deeplink (#1047)

* handle ens

* handle undefined

* handleNewTxMetaRecipient

* fail to undefined

* update data

* bugfix: connect modal (#1048)

* dont show invalid deeplink if opening the app with no action (#1050)

* updated branch sdk and fix build (#1051)

* updated branch sdk and fix build

* use ssh for git cloning submodules

* fix dep versions

* Detox: Import seed phrase and validate via settings (#1056)

* imported seed phrase and validated in settings

* renamed other tests back to what it was prior

* updated snaps

* Update branch SDK & fix build issues (#1061)

* update branch-sdk no webviews

* use commit sha instead of branch

* bump circleci cache version (#1062)

* Revert "Update branch SDK & fix build issues (#1061)" (#1063)

This reverts commit 60dfb78.

* Fix circleci builds (#1064)

* fix circleci builds

* bump cache again

* bugfix: remove tokens but ETH (#1054)

* bugfix: inpage enable (#1065)

* Bugfix: custom rpc network (#1060)

* fix crash

* use ticker

* snaps

* forgot ticker

* fix unknown ticker

* snaps

* bugfix: android injection (#1068)

* fix ens manager (#1069)

* bugfix: json rpc accounts api (#1071)

* detox: dapp initiated txns (#1058)

* automated dapp txns

* finished rest of dapp interaction flow

* recommended updates

* safe check (#1076)

* Update branch to latest version (#1078)

* fix branch no webview building

* use latest version of branch ios SDK

* fix mainapplication.java

* update submodules (#1079)

* Fix android builds (#1080)

* fix android builds

* more webview removal

* more fixes

* use frozen lockfile in ci

* fix

* fix linter errors

* Fix webview files path (#1081)

* fix android builds

* more webview removal

* more fixes

* use frozen lockfile in ci

* fix

* fix linter errors

* fix webview files path

* dont use cache on pre-release (#1082)

* dont use cache on pre-release

* more clean up

* bugfix: reveal credential ui (#1084)

* padding

* snaps

* Revert "dont use cache on pre-release (#1082)" (#1086)

This reverts commit ae735a1.

* Revert "Fix webview files path (#1081)" (#1087)

This reverts commit c376cd6.

* Revert "Fix android builds (#1080)" (#1088)

This reverts commit c3459fe.

* Revert "update submodules (#1079)" (#1089)

This reverts commit 561eb01.

* Revert "Update branch to latest version (#1078)" (#1090)

This reverts commit f53aa69.

* fix android apk generation (#1091)

* use old xcode to compare build diff (#1092)

* fix Crashlytics import (#1093)

* update deps and xcode (#1094)

* detox: Enable e2e test suite to run on CircleCI (#1097)

* fix keyboard issues

* update MM source app annotation

* detox: test e2e ios (#1075)

* test e2e ios

* ios release

* add

* xcconfig

* which node

* bundle resource

* Revert "bundle resource"

This reverts commit aea75bc.

* xcode image

* comment unit test

* 12.4

* steps

* prefix

* fastlane

* debug

* development

* dev

* debug

* adhoc

* debug

* ashoc

* rollback

* rm debug

* wait for unit

* rm fastlane mods

* write xcconfig

* delay

* timeout

* update dapp txn flow in case ropsten faucet is having issues (#1101)

* Update README.md (#1106)

* Feature: onboarding carousel (#1103)

* onboarding carousel

* debug

* working

* locale

* es

* snapsgots

* onboarding updates

* locales

* import wallet

* more ui

* onboarding background

* create wallet

* android tweaks

* navbar

* navigation

* add additional steps to e2e

* flag

* stack

* snapshots

* Feature: instapay receive (#1104)

* card qr

* instapay ok

* done

* snapshots

* comment

* margin

* improvements: instapay (#1108)

* alerts and gas

* locale

* typo:

* missing locale

* add app constant

* fix locale

* Webview rewrite (#1096)

* webview rewrite in progress

* some fixes

* update deps

* update unit tests

* clear cache

* android injection working

* add missing props

* remove UIWebview imports from react native

* fix CI caching issues on dev

* update branch sdk

* set yarn network concurrency = 1 for CI

* update react-native-branch

* fix postinstall

* postinstall fix

* update react-native-webview

* fix token rendering

* fix favorites

* fix alert crash

* bugfixes

* fixes

* fix import

* bump react-native-webview

* bump to v0.2.5 (#1112)

* Fix develop builds (#1113)

* bump to v0.2.5

* fix develop builds

* Bump react-native-device-info (#1115)

* bump

* update changelog

* update yarn lockfile

* increase gradle memory

* iOS 13 Support (#1116)

* bump react-native-aes to latest version

* use xCode 11.1

* update simulator

* fix e2e tests

* update lockfile

* set placeholder color everywhere

* replace text instead of select and clear

* temp. disable ropsten faucet e2e test

* disable logout test

* fix snapshots

* more snapshot fixes

* more snapshot fixes

* Bump rubyzip from 1.2.3 to 1.3.0 in /ios (#1119)

Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.3 to 1.3.0.
- [Release notes](https://github.com/rubyzip/rubyzip/releases)
- [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md)
- [Commits](rubyzip/rubyzip@v1.2.3...v1.3.0)

Signed-off-by: dependabot[bot] <[email protected]>

* fix webview black flash (#1120)

* Fix walletconnect sendTransaction (#1121)

* bump wc

* update lockfile

* fix walletconnect

* fix statusbar in dark mode (#1122)

* Support provider.once (#1123)

* support provider.once

* Fix typo

* fix apk generation (#1124)

* update user agents (#1125)

* Fix: Add tokens android crash (#1127)

* bump react-native-remote-svg

* fix add tokens crash

* Navigation fixes (#1128)

* navigation fixes

* fix indentation

* linter bs

* fix instapay crash

* fix unit tests

* Design QA issues (#1129)

* update title

* update snapshots

* update snapshots

* Bugfix: onboarding design qa (#1130)

* test

* test

* stack and buttons

* image 3

* snaps

* add ratio

* snaps

* Bugfix: wizard design qa (#1131)

* fix iphone 11 issue

* step 4

* step 4 for real

* fix step6 back

* Fix animated fox (#1132)

* update

* update react-native-animated-fox

* fix unit tests

* fix sensors missing error

* renew certs if needed (#1134)

* Fix fastlane config (#1135)

* fix fastlane config

* fix version

* Select correct profiles (#1136)

* fix fastlane config

* fix version

* select correct profiles after clean up

* select correct profiles after clean up

* update changelog (#1137)
@estebanmino estebanmino deleted the bugfix/custom-rpc-network branch November 22, 2019 14:25
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Bugfix: custom rpc network (#1060)
832263f 
* fix crash

* use ticker

* snaps

* forgot ticker

* fix unknown ticker

* snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
4 participants
@estebanmino @yourihua @ibrahimtaveras00 @brunobar79