Improvement: approval token transfer data #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
added
the
needs-qa
…hub.com/MetaMask/metamask-mobile into improvement/approval-token-tranfer-data
ibrahimtaveras00
approved these changes
Aug 27, 2019
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* get symbol and decimals * snaps * use local tokens first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to fetch token information when a token transfer is happening.
If the information fetch fails, it will default to
ERC20as symbol and 0 decimals, the extensions sets decimals to 0 without symbol.Besides QAing the feature itself, would be nice to have a QA pass through dapps that trigger token tranfers.
Checklist
Issue
Resolves #1022