Bugfix: phishing alerts #1007
Merged
Bugfix: phishing alerts #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
added
the
needs-qa
brunobar79
approved these changes
Aug 19, 2019
There was a problem hiding this comment.
This looks good and appreciate the additional clean up 🙌
@ibrahimtaveras00 We're gonna need heavy QA on:
- Phishing urls, typing in the search bar and navigating to a phishing site via link
- Bottom navbar navigation (back & fwd buttons)
- ENS => IPFS urls
|
Still seeing the crash = https://recordit.co/6GrKpWR9bg |
ibrahimtaveras00
approved these changes
Aug 27, 2019
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* clean * clean ens * fixed for ios * handleNotAllowedUrl from onpasgechange * rm unnecessary code * more * fix reload issue * redo reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #899
https://recordit.co/bPEIbkk0jK
Checklist
Issue
Resolves #???