Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24 word seed phrase #1838

Closed
andreaslillevangbech opened this issue Sep 18, 2020 · 2 comments · Fixed by #1848
Closed

24 word seed phrase #1838

andreaslillevangbech opened this issue Sep 18, 2020 · 2 comments · Fixed by #1848

Comments

@andreaslillevangbech
Copy link

Describe the usability problem
A clear and concise description of the specific usability issue

Screenshots
If applicable, add screenshots or links to help explain the issue

Expected behavior
If possible, a clear and concise description / resolution of what you expected to happen

filled out after submission

User impact | Usage frequency | Feasibility scores
How important is this to the user, what the user wants to accomplish | Daily, weekly, monthly | Small, medium, large
@andreaslillevangbech
Copy link
Author

It doesnt accect 24 word phrases. Only works with 12 in the mobile app

@rickycodes rickycodes mentioned this issue Sep 24, 2020
Merged
3 tasks
rickycodes added a commit that referenced this issue Sep 24, 2020
@rickycodes
Allow for 24 length seedphrase on import, closes #1838
cee83ff
rickycodes added a commit that referenced this issue Sep 28, 2020
@rickycodes
Allow for 24 length seedphrase on import, closes #1838
3bc5f55
rickycodes added a commit that referenced this issue Sep 28, 2020
@rickycodes
Allow for 24 length seedphrase on import (#1848)
ebe4745 
* Allow for 24 length seedphrase on import, closes #1838

* call toggleHideSeedPhraseInput onScanError

* Update broken seed phrase translation keys

* Add proper logging for when seed phrase does fail

* Validate mnemonic with ethers

* Add tests for failedSeedPhraseRequirements
rickycodes added a commit that referenced this issue Jan 31, 2022
@rickycodes
Allow for 24 length seedphrase on import (#1848)
82f8f77 
* Allow for 24 length seedphrase on import, closes #1838

* call toggleHideSeedPhraseInput onScanError

* Update broken seed phrase translation keys

* Add proper logging for when seed phrase does fail

* Validate mnemonic with ethers

* Add tests for failedSeedPhraseRequirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow for 24 length seedphrase on import MetaMask/metamask-mobile
2 participants
@andreaslillevangbech and others