Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On current develop, padding is off on edit gas modal #1664

Closed
ibrahimtaveras00 opened this issue Jun 30, 2020 · 1 comment · Fixed by #1671
Closed

On current develop, padding is off on edit gas modal #1664

ibrahimtaveras00 opened this issue Jun 30, 2020 · 1 comment · Fixed by #1671
Assignees
@rickycodes
Labels
release-blocker This bug is blocking the next release type-bug Something isn't working

Comments

@ibrahimtaveras00
Copy link
Contributor

Describe the bug

Padding is off on the edit gas modal

Screenshots

image

To Reproduce

  1. Initiate Send flow and select an amount to send
  2. Go to Confirm view
  3. Tap on edit (for txn fee)

Expected behavior

Padding should be aligned correctly

Screen Shot 2020-06-30 at 6 20 49 PM

Smartphone (please complete the following information):

  • Device: Android + iPhone
  • OS: any
  • Version current develop branch

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@ibrahimtaveras00 ibrahimtaveras00 added the type-bug Something isn't working label Jun 30, 2020
@rickycodes
Copy link
Contributor

Fairly certain I introduced in this #1558 af69702e

@ibrahimtaveras00 ibrahimtaveras00 added the release-blocker This bug is blocking the next release label Jun 30, 2020
@rickycodes rickycodes self-assigned this Jul 1, 2020
rickycodes added a commit that referenced this issue Jul 3, 2020
@rickycodes
Remove minWidth, fixes #1664
2f1b820
@rickycodes rickycodes mentioned this issue Jul 3, 2020
Merged
3 tasks
rickycodes added a commit that referenced this issue Jul 7, 2020
@rickycodes
Remove minWidth, fixes #1664
2a6e012
rickycodes added a commit that referenced this issue Jul 7, 2020
@rickycodes
Remove minWidth, fixes #1664 (#1671)
7299956
rickycodes added a commit that referenced this issue Jan 31, 2022
@rickycodes
Remove minWidth, fixes #1664 (#1671)
c8d4ad7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickycodes rickycodes

Labels
release-blocker This bug is blocking the next release type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove minWidth, fixes #1664 MetaMask/metamask-mobile
2 participants
@rickycodes @ibrahimtaveras00