Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NetworkController across Mobile dependency tree #11910

Closed
12 tasks done
mikesposito opened this issue Oct 21, 2024 · 1 comment
Closed
12 tasks done

Update NetworkController across Mobile dependency tree #11910

mikesposito opened this issue Oct 21, 2024 · 1 comment
Assignees
@mikesposito
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-wallet-framework

Comments

@mikesposito
Copy link
Member

mikesposito commented Oct 21, 2024 •
edited
Loading

We currently have four different @metamask/network-controller major versions in the dependency tree:

v21 (target version)

yarn why output 
=> Found "@metamask/[email protected]"
info Has been hoisted to "@metamask/network-controller"
info This module exists because it's specified in "dependencies".
info Disk size without dependencies: "5.07MB"
info Disk size with unique dependencies: "17.91MB"
info Disk size with transitive dependencies: "39.14MB"
info Number of shared dependencies: 60

This is the correct version to have

v20

yarn why output 
=> Found "@metamask/smart-transactions-controller#@metamask/[email protected]"
info This module exists because "@metamask#smart-transactions-controller" depends on it.
info Disk size without dependencies: "3.17MB"
info Disk size with unique dependencies: "15.18MB"
info Disk size with transitive dependencies: "36.98MB"
info Number of shared dependencies: 59

v19

yarn why output 
=> Found "@metamask/polling-controller#@metamask/[email protected]"
info This module exists because "@metamask#polling-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

=> Found "@metamask/assets-controllers#@metamask/[email protected]"
info This module exists because "@metamask#assets-controllers" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

=> Found "@metamask/gas-fee-controller#@metamask/[email protected]"
info This module exists because "@metamask#gas-fee-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

=> Found "@metamask/selected-network-controller#@metamask/[email protected]"
info This module exists because "@metamask#selected-network-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

=> Found "@metamask/smart-transactions-controller#@metamask/transaction-controller#@metamask/[email protected]"
info This module exists because "@metamask#smart-transactions-controller#@metamask#transaction-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

v17

yarn why output 
=> Found "@metamask/swaps-controller#@metamask/[email protected]"
info Reasons this module exists
   - "@metamask#swaps-controller#@metamask#gas-fee-controller" depends on it
   - Hoisted from "@metamask#swaps-controller#@metamask#gas-fee-controller#@metamask#network-controller"
   - Hoisted from "@metamask#swaps-controller#@metamask#gas-fee-controller#@metamask#polling-controller#@metamask#network-controller"
info Disk size without dependencies: "452KB"
info Disk size with unique dependencies: "11.67MB"
info Disk size with transitive dependencies: "35.82MB"
info Number of shared dependencies: 59
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Oct 21, 2024
@mikesposito mikesposito self-assigned this Oct 22, 2024
This was referenced Nov 21, 2024
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 21, 2024
@mikesposito
build(deps): bump @metamask/selected-network-controller to ^18.0.2 (
ff51656 
#12004)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR bumps the `@metamask/selected-network-controller` package to
`^18.0.2`

See the package
[changelog](https://github.com/MetaMask/core/blob/main/packages/selected-network-controller/CHANGELOG.md)
for details

## **Related issues**

Related to: #11910

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
github-merge-queue bot pushed a commit that referenced this issue Nov 21, 2024
@mikesposito
build(deps): bump @metamask/smart-transaction-controller to `^14.0.…
feb6bf8 
…0` (#12003)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR bumps `@metamask/smart-transaction-controller` to version
`^14.0.0`. See the package
[changelog](https://github.com/MetaMask/smart-transactions-controller/blob/main/CHANGELOG.md)
for changes details


## **Related issues**

Related to: #11910

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
github-merge-queue bot pushed a commit that referenced this issue Nov 26, 2024
@mikesposito
chore(deps): bump @metamask/{swaps, gas-fee}-controller (#12368)
e7cff66 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
 
This PR bumps `@metamask/swaps-controller` to `^11.0.0` and
`@metamask/gas-fee-controller` to `^21.0.0` (to match swaps-controller's
peer dependency requirements). See package changelogs for details on
changes:
-
[swaps-controller](https://github.com/MetaMask/swaps-controller/blob/main/CHANGELOG.md)
-
[gas-fee-controller](https://github.com/MetaMask/core/blob/main/packages/gas-fee-controller/CHANGELOG.md)

## **Related issues**

Related to: #11910

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@mikesposito
Copy link
Member Author

This has been completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikesposito mikesposito

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikesposito @metamaskbot