Validate mnemonic with ethers

MetaMask · Sep 25, 2020 · d3ab579 · d3ab579
1 parent f424edc
commit d3ab579
Show file tree

Hide file tree

Showing 3 changed files with 391 additions and 30 deletions.
diff --git a/app/components/Views/ImportFromSeed/index.js b/app/components/Views/ImportFromSeed/index.js
@@ -41,10 +41,11 @@ import {
 	METRICS_OPT_IN,
 	TRUE
 } from '../../../constants/storage';
-// TODO:
-// import { validateMnemonic } from 'bip39';
+import { ethers } from 'ethers';
 import Logger from '../../../util/Logger';
 
+const { isValidMnemonic } = ethers.utils;
+
 const styles = StyleSheet.create({
 	mainWrapper: {
 		backgroundColor: colors.white,
@@ -252,13 +253,10 @@ class ImportFromSeed extends PureComponent {
 
 		if (failedSeedPhraseRequirements(seed)) {
 			error = strings('import_from_seed.seed_phrase_requirements');
+		} else if (!isValidMnemonic(seed)) {
+			error = strings('import_from_seed.invalid_seed_phrase');
 		}
 
-		// TODO: do bip39 validate
-		// else if (!validateMnemonic(seed)) {
-		// 	error = strings('import_from_seed.invalid_seed_phrase');
-		// }
-
 		if (error) {
 			Alert.alert(strings('import_from_seed.error'), error);
 		} else {

diff --git a/package.json b/package.json
@@ -102,7 +102,7 @@
     "eth-url-parser": "1.0.2",
     "ethereumjs-abi": "0.6.6",
     "ethereumjs-util": "6.1.0",
-    "ethers": "4.0.27",
+    "ethers": "^5.0.14",
     "ethjs-contract": "0.2.3",
     "ethjs-ens": "2.0.1",
     "ethjs-query": "0.3.8",