Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet_openDeepLink rpc method #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

hmalik88
Copy link

This PR aims to add a specification for the wallet_openDeepLink method. The motivation behind this adding this functionality is to make use of MetaMask URLs to be able to programmatically navigate to different parts of our clients and snaps.

@vandan
Copy link
Collaborator

vandan commented Sep 19, 2024

Sounds like we should add some information about the expected return values in here.

@vandan
Copy link
Collaborator

vandan commented Sep 19, 2024

Would we want to enable a flow where:
dapp --deeplinks to--> MetaMask internal URL -> some action is completed --MetaMask redirects to --> dapp URL

Essentially supporting a "return URL" similar to the behavior at the end of onboarding when wallet_registerOnboarding is used to return the user to the dapp that initiated wallet onboarding.

@hmalik88
Copy link
Author

hmalik88 commented Oct 3, 2024

I think the wallet onboarding is a unique flow, I can't think of other use cases where deep links kick you back somewhere. We would have to keep state of the ongoing actions and track when they're completed, which just completely blows the scope of this feature and not really in line with a simple deep link imo. I'd like to keep this as simple as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants