Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xDai chain support by default #7492

Closed
wants to merge 1 commit into from

Conversation

vbaranov
Copy link
Contributor

@vbaranov vbaranov marked this pull request as ready for review November 22, 2019 14:10
@rstormsf
Copy link

@whymarrh any feedback on this?

@whymarrh whymarrh mentioned this pull request Feb 12, 2020
@whymarrh
Copy link
Contributor

Hey, @vbaranov, thanks for putting this together. (@rstormsf thanks for the ping.) As I commented over on the Pocket Network PR, the network list can't be extended to include everyone's networks and we don't have a way of honestly choosing among all the possible networks. As noted in the Twitter thread linked in the OP, our forthcoming plugin system may very well be a way to introduce some extensibility to MetaMask's understanding of networks.

I'm closing this for now, but #3604 and #5101 are relevant here, as ideally we should have a way to allow sites (or plugins) to add new networks and we welcome new ideas on this front.

@anxolin
Copy link

anxolin commented Oct 14, 2020

When will we see this PR in a release?

@github-actions
Copy link
Contributor

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
@vbaranov

@anxolin
Copy link

anxolin commented Oct 14, 2020

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants