network - infura - hardcode net_version and eth_chainId #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kumavis What about custom networks? Such as #1820 (comment) |
|
@danjm doesnt touch custom networks, only infura based networks |
|
for non-infura networks, it will just pass through to the node |
danjm
approved these changes
Nov 5, 2018
bitpshr
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5664
When using infura based networks, handle
net_versionandeth_chainIdrequests in the client via value set based on the selected network name (eg"mainnet""ropsten")besides skipping unnecessary network requests, this supports
eth_chainIdahead of infura releasing support for that method