Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: issue #4510 #5187

Closed
wants to merge 2 commits into from
Closed

WIP: issue #4510 #5187

wants to merge 2 commits into from

Conversation

Rohithzr
Copy link

@Rohithzr Rohithzr commented Sep 3, 2018

TODO:

  • pass the selected primary currency in props
  • use the props to change the text of the confirmation screen

@Rohithzr
- added en locale translation
79c6ad1 
- dropdown css will now adjust to shorter heights (max-height: 220px)
- added option to select primary currency in settings (issue MetaMask#4510)
@bdresser bdresser closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextsg alextsg Awaiting requested review from alextsg

@danjm danjm Awaiting requested review from danjm

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rohithzr @bdresser