Show transaction error message tooltips for statuses #5128
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the tx doesn't have a human readable RPC error messgae we can default to the `err.message` value (or nothing if it's not defined). Some of the non-RPC errors will have useful stringified values as their message despite the RPC errors having atrocious error messages.
alextsg
approved these changes
Aug 23, 2018
|
@whymarrh possible to use the nice black tooltips we have in the extension? just asking cuz I know christian gonna ask when he sees it 😬 |
|
@bdresser the thinking was that the new UI uses the black tooltips for actions/buttons and where these tooltips are more informational that it wouldn't be a good fit—good point though, we'll run it by Christian in next design chat and update it |
|
I know that he wanted to use the black tooltip to explain the "pending" state (MetaMask/Design#25 (comment)) so probably would work for all of em -- we can double check in design sync tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3768
This PR updates the
TransactionStatuscomponent to accept an optionaltitleprop and theTransactionListItemto use the transaction's error message as the title if it exists.Pics or it didn't happen
In the best case a new
txMetawill have the RPC error message directly on it:If there's no error we'll have just the status:
In the worst case, we're showing this monstrosity:
Initially I didn't want to have
txMeta.err.messagein the title but in some (non-RPC) cases that's the best we've got and it contains useful information.