fix: multichain account icon address source #35859

gantunesr · 2025-09-11T21:17:20Z

Description

Adds new selector to select the source address for an account group to be used as a seed for the icon generation.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

Open the account list
Check the icons are correctly generated

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…into gar/fix/account-icons

metamaskbot · 2025-09-11T21:19:36Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (7 files, +136 -56)

📁 ui/
- 📁 components/
  - 📁 multichain-accounts/
    - 📁 multichain-account-cell/
      - 📄 multichain-account-cell.test.tsx +1 -1
      - 📄 multichain-account-cell.tsx +6 -1
    - 📁 multichain-account-list/
      - 📄 multichain-account-list.test.tsx +21 -7
- 📁 pages/
  - 📁 multichain-accounts/
    - 📁 multichain-accounts-connect-page/
      - 📁 __snapshots__/
        
        📄 multichain-accounts-connect-page.test.tsx.snap +24 -24
        
        📄 multichain-accounts-connect-page.test.tsx +22 -22
- 📁 selectors/
  - 📁 multichain-accounts/
    - 📄 account-tree.test.ts +32 -0
    - 📄 account-tree.ts +30 -1

metamaskbot · 2025-09-11T21:48:47Z

📊 Page Load Benchmark Results

Current Commit: 829eb62 | Date: 9/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.10s ⬇️ (historical data)
domContentLoaded-> current mean value: 730ms (±68ms) 🟢 | historical mean value: 784ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±12ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	71ms	1.01s	1.31s	1.26s	1.31s
domContentLoaded	730ms	68ms	698ms	996ms	930ms	996ms
firstPaint	75ms	12ms	56ms	176ms	84ms	176ms
firstContentfulPaint	75ms	12ms	56ms	176ms	84ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-11T21:48:52Z

Builds ready [829eb62]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1270 ± 74 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1270	1134	1508	74	1307	1392
			load	1099	984	1318	67	1149	1205
			domContentLoaded	1091	978	1301	67	1142	1199
			domInteractive	19	14	52	8	18	45
			firstPaint	678	90	1241	446	1099	1183
			backgroundConnect	249	238	279	7	253	262
			firstReactRender	25	18	51	6	27	37
			getState	15	5	90	11	18	28
			initialActions	4	0	22	4	5	10
			loadScripts	849	736	1039	66	897	965
			setupStore	10	5	19	3	11	16
	Webpack	Home	uiStartup	1990	1535	2666	268	2171	2478
			load	1590	1234	1992	213	1740	1911
			domContentLoaded	1580	1220	1980	214	1729	1891
			domInteractive	18	12	86	14	15	54
			firstPaint	158	65	361	56	175	277
			backgroundConnect	42	16	408	68	32	90
			firstReactRender	86	37	338	64	84	294
			getState	21	5	301	48	13	28
			initialActions	6	2	29	5	6	20
			loadScripts	1576	1217	1968	212	1727	1879
			setupStore	23	6	301	53	14	63
Firefox	Browserify	Home	uiStartup	1340	1198	1808	108	1391	1526
			load	1164	1054	1376	73	1215	1297
			domContentLoaded	1164	1054	1376	73	1215	1297
			domInteractive	99	32	280	47	106	219
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	17	124	18	34	79
			firstReactRender	26	22	62	5	28	35
			getState	8	2	185	20	6	14
			initialActions	5	0	94	12	3	13
			loadScripts	1140	1006	1349	71	1199	1247
			setupStore	10	4	96	13	7	35
	Webpack	Home	uiStartup	1599	1398	2063	153	1696	1888
			load	1362	1177	1728	136	1459	1620
			domContentLoaded	1362	1176	1727	136	1459	1620
			domInteractive	110	32	388	70	105	310
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	22	80	8	38	46
			firstReactRender	46	37	74	5	48	56
			getState	6	3	18	2	6	9
			initialActions	3	1	13	2	3	7
			loadScripts	1338	1150	1709	136	1437	1597
			setupStore	9	5	66	7	9	15

Benchmark value 1270 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1099 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1092 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 249 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 850 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1392 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1206 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1199 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 46 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 966 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 43 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 2478 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 20 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 219 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 79 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 310 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 56 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 408ms | Sum of p95 exceeds: 603.8ms
Sum of all benchmark exceeds: 1011.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 664 Bytes (0.01%)
common: 10 Bytes (0%)

owencraston · 2025-09-11T21:51:16Z

Account seed seems to be working properly!

Without feature flag:

with feature flag:

I also verified that the same icons are rendered when you import the same SRP/PK into mobile

Simulator Screenshot - iPhone 16 Plus - 2025-09-11 at 18 09 45

ui/selectors/multichain-accounts/account-tree.ts

owencraston · 2025-09-11T22:11:34Z

ui/selectors/multichain-accounts/account-tree.ts

+    console.log('Accounts in group for icon seed:', accounts);
+    if (!accounts || accounts.length === 0) {
+      throw new Error(
+        'Error in getIconSeedAddressByAccountGroupId: No accounts found in the specified group',


we should put the group id in the log so we can check the state logs if we see issues with this.

metamaskbot · 2025-09-12T00:11:45Z

📊 Page Load Benchmark Results

Current Commit: dfd204c | Date: 9/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.10s ⬇️ (historical data)
domContentLoaded-> current mean value: 736ms (±69ms) 🟢 | historical mean value: 784ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	71ms	1.01s	1.32s	1.29s	1.32s
domContentLoaded	736ms	69ms	702ms	1.01s	970ms	1.01s
firstPaint	76ms	12ms	60ms	172ms	92ms	172ms
firstContentfulPaint	76ms	12ms	60ms	172ms	92ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-12T00:12:02Z

Builds ready [dfd204c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1107	1441	60	1259	1329
			load	1055	943	1222	57	1088	1150
			domContentLoaded	1048	933	1214	57	1081	1141
			domInteractive	19	14	49	8	18	41
			firstPaint	615	139	1178	419	1060	1116
			backgroundConnect	246	231	270	7	250	260
			firstReactRender	27	17	87	9	29	43
			getState	14	5	34	7	18	30
			initialActions	5	0	19	3	6	11
			loadScripts	809	688	968	57	843	905
			setupStore	10	6	25	4	12	18
	Webpack	Home	uiStartup	1960	1450	2521	271	2151	2407
			load	1575	1172	1971	210	1700	1911
			domContentLoaded	1567	1167	1967	209	1689	1907
			domInteractive	17	12	82	13	14	52
			firstPaint	160	69	313	53	185	276
			backgroundConnect	32	14	322	39	30	55
			firstReactRender	82	37	325	61	79	320
			getState	27	5	290	62	14	265
			initialActions	13	2	287	44	6	24
			loadScripts	1564	1165	1957	207	1687	1896
			setupStore	14	6	232	22	13	23
Firefox	Browserify	Home	uiStartup	1469	1256	1943	110	1514	1660
			load	1268	1096	1494	80	1315	1430
			domContentLoaded	1267	1096	1494	80	1314	1429
			domInteractive	110	36	326	56	112	237
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	40	22	175	25	38	107
			firstReactRender	29	24	57	5	30	37
			getState	7	3	60	7	7	16
			initialActions	4	1	41	6	3	11
			loadScripts	1236	1076	1466	78	1291	1359
			setupStore	12	5	226	23	9	30
	Webpack	Home	uiStartup	1562	1375	1880	141	1660	1843
			load	1337	1155	1688	130	1444	1587
			domContentLoaded	1336	1155	1688	130	1444	1587
			domInteractive	105	33	309	61	102	284
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	21	53	7	36	41
			firstReactRender	43	36	61	5	46	54
			getState	6	3	20	2	6	9
			initialActions	5	1	145	18	3	10
			loadScripts	1314	1123	1671	131	1425	1568
			setupStore	10	5	153	15	9	16

Benchmark value 246 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 265 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 24 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1470 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1268 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1268 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 41 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1236 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 237 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 107 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 284 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 423ms | Sum of p95 exceeds: 570.8ms
Sum of all benchmark exceeds: 993.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 664 Bytes (0.01%)
common: 10 Bytes (0%)

…into gar/fix/account-icons

ui/selectors/multichain-accounts/account-tree.ts

metamaskbot · 2025-09-12T13:48:34Z

📊 Page Load Benchmark Results

Current Commit: 057c6af | Date: 9/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 723ms (±68ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±15ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	70ms	995ms	1.31s	1.24s	1.31s
domContentLoaded	723ms	68ms	690ms	979ms	926ms	979ms
firstPaint	75ms	15ms	56ms	204ms	92ms	204ms
firstContentfulPaint	75ms	15ms	56ms	204ms	92ms	204ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-12T13:48:44Z

Builds ready [057c6af]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1245 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1245	1109	1356	61	1294	1340
			load	1069	924	1175	64	1114	1163
			domContentLoaded	1062	914	1170	64	1110	1157
			domInteractive	18	14	57	7	17	37
			firstPaint	766	130	1183	414	1095	1161
			backgroundConnect	249	235	275	7	253	262
			firstReactRender	28	17	126	19	27	50
			getState	15	5	90	11	17	34
			initialActions	5	1	52	7	6	14
			loadScripts	821	673	928	63	869	913
			setupStore	10	6	32	3	10	14
	Webpack	Home	uiStartup	2102	1650	2806	249	2237	2563
			load	1687	1277	2306	207	1808	2033
			domContentLoaded	1677	1269	2300	209	1802	2022
			domInteractive	18	13	79	12	16	47
			firstPaint	165	67	380	67	184	307
			backgroundConnect	35	18	341	42	32	54
			firstReactRender	94	40	342	65	94	315
			getState	27	5	329	62	15	278
			initialActions	6	2	27	4	6	16
			loadScripts	1670	1267	2289	211	1798	2010
			setupStore	18	6	265	31	16	27
Firefox	Browserify	Home	uiStartup	1359	1179	1837	109	1397	1602
			load	1179	1034	1336	68	1228	1301
			domContentLoaded	1179	1034	1336	68	1228	1301
			domInteractive	103	32	303	51	103	231
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	19	74	8	33	41
			firstReactRender	26	22	36	3	28	30
			getState	7	3	73	8	6	15
			initialActions	6	1	192	25	3	9
			loadScripts	1157	1018	1313	68	1209	1277
			setupStore	11	4	197	22	7	36
	Webpack	Home	uiStartup	1590	1404	1984	153	1679	1907
			load	1356	1184	1780	134	1452	1592
			domContentLoaded	1356	1184	1780	134	1452	1591
			domInteractive	103	33	310	59	100	281
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	21	95	9	38	41
			firstReactRender	46	36	116	9	47	57
			getState	6	3	15	2	7	12
			initialActions	5	1	146	15	3	8
			loadScripts	1332	1157	1761	135	1431	1570
			setupStore	10	5	150	15	9	21

Benchmark value 1245 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1062 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 249 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 50 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2563 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2033 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2023 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 278 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2011 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 231 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 281 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 298ms | Sum of p95 exceeds: 715.8ms
Sum of all benchmark exceeds: 1013.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 568 Bytes (0.01%)
common: 10 Bytes (0%)

gantunesr added 3 commits September 11, 2025 09:32

chore: add getIconSeedAddressByAccountGroupId

b02b63c

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

d7f1672

…into gar/fix/account-icons

chore: update address source

1b70cb0

metamaskbot added the team-accounts label Sep 11, 2025

github-actions bot added the size-S label Sep 11, 2025

test: fix unit test

829eb62

gantunesr marked this pull request as ready for review September 11, 2025 21:28

gantunesr requested a review from a team as a code owner September 11, 2025 21:28

This comment was marked as outdated.

Sign in to view

owencraston reviewed Sep 11, 2025

View reviewed changes

ui/selectors/multichain-accounts/account-tree.ts Outdated Show resolved Hide resolved

owencraston reviewed Sep 11, 2025

View reviewed changes

test: fix MultichainConnectPage tests

dfd204c

github-actions bot added size-M and removed size-S labels Sep 11, 2025

test: fix MultichainAccountList mocks

0c7a4f4

This comment was marked as outdated.

Sign in to view

gantunesr added 2 commits September 12, 2025 10:21

chore: remove only from test

a1f279f

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

057c6af

…into gar/fix/account-icons

cursor bot reviewed Sep 12, 2025

View reviewed changes

ui/selectors/multichain-accounts/account-tree.ts Show resolved Hide resolved

owencraston approved these changes Sep 12, 2025

View reviewed changes

PatrykLucka approved these changes Sep 12, 2025

View reviewed changes

gantunesr added this pull request to the merge queue Sep 12, 2025

Any commits made after this event will not be merged.

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2025

gantunesr enabled auto-merge September 12, 2025 18:13

gantunesr added this pull request to the merge queue Sep 12, 2025

Any commits made after this event will not be merged.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: multichain account icon address source #35859

fix: multichain account icon address source #35859

gantunesr commented Sep 11, 2025 •

edited by github-actions bot

Loading

Uh oh!

metamaskbot commented Sep 11, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 11, 2025

Uh oh!

metamaskbot commented Sep 11, 2025

Uh oh!

owencraston commented Sep 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

owencraston Sep 11, 2025

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

Uh oh!

Uh oh!

fix: multichain account icon address source #35859

fix: multichain account icon address source #35859

Conversation

gantunesr commented Sep 11, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 11, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 11, 2025

Uh oh!

owencraston commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

owencraston Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Sep 12, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

metamaskbot commented Sep 12, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

Uh oh!

Uh oh!

gantunesr commented Sep 11, 2025 •

edited by github-actions bot

Loading

metamaskbot commented Sep 11, 2025 •

edited

Loading

owencraston commented Sep 11, 2025 •

edited

Loading