Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix SignatureController hub cancelWithReason event handler #29673

Merged

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Jan 13, 2025

Description

This PR aims to fix cancelWithReason event handler which is causing rejectPendingApprovals to be hang and throw.

Open in GitHub Codespaces

Related issues

Fixes: #29663

Manual testing steps

  1. Create multiple signature request without accept or reject
  2. Close notification window
  3. See that no more badge number in extension bar

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz linked an issue Jan 13, 2025 that may be closed by this pull request
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 13, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [a0160fb]
Page Load Metrics (1788 ± 136 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38929571719415199
domContentLoaded155028861755275132
load156529611788284136
domInteractive25109412411
backgroundConnect1274342211
firstReactRender1699523216
getState55713157
initialActions01000
loadScripts11421956130116981
setupStore790232814
uiStartup177632022197330159
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit e8b52cd Jan 14, 2025
82 checks passed
@OGPoyraz OGPoyraz deleted the 29663-bug-closing-notification-doesnt-reject-pending-approvals branch January 14, 2025 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Closing notification doesn't reject pending approvals
4 participants