Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(26772): improve helptext for sending NFTs #29296

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Dec 17, 2024

Description

Helper text for sending NFTs to another address is not accurate. We got feedback from design to implement the following:

Balance: 1 NFT  or
Balance: [2-1000000] NFTs

Open in GitHub Codespaces

Related issues

Fixes: #26772

Manual testing steps

  1. Select an NFT
  2. Send NFT to another address
  3. Check the message

Screenshots/Recordings

Before

2

After

Screenshot 2024-12-17 at 16 34 22 Screenshot 2024-12-17 at 16 34 42

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica self-assigned this Dec 17, 2024
@DDDDDanica DDDDDanica requested a review from a team as a code owner December 17, 2024 19:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

balanceColor={'textColor' as TextColor}
/>
</Provider>,
const { asFragment } = renderWithProvider(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using renderWithProvider to access I18nProvider

@DDDDDanica DDDDDanica force-pushed the fix/26772-import-nft-reword branch 2 times, most recently from 8fdd356 to 1599efc Compare December 17, 2024 21:07
@DDDDDanica DDDDDanica force-pushed the fix/26772-import-nft-reword branch from 1599efc to 74d2722 Compare December 17, 2024 21:10
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

  • checked sending single NFT ✅
  • checked insufficient balance error message ✅
  • did not check multiple NFTs

@metamaskbot
Copy link
Collaborator

Builds ready [74d2722]
Page Load Metrics (1746 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24621041603466224
domContentLoaded15092094172014368
load15302119174614368
domInteractive278746199
backgroundConnect881282110
firstReactRender16177624722
getState583192210
initialActions01000
loadScripts11171633128711756
setupStore675222311
uiStartup175424862078236114
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 31 Bytes (0.00%)
  • common: 86 Bytes (0.00%)

@DDDDDanica DDDDDanica added this pull request to the merge queue Dec 18, 2024
@DDDDDanica
Copy link
Contributor Author

@georgewrmarshall thanks for checking ! i didn't find a way to send multiple nfts, but i used unit tests to cover the case to validate the content 🙌🏻

Merged via the queue into main with commit 9020abf Dec 18, 2024
77 checks passed
@DDDDDanica DDDDDanica deleted the fix/26772-import-nft-reword branch December 18, 2024 00:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-extension-platform Extension Platform team team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Helptext for NFTs says, “Balance 1 token”
4 participants