-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(26772): improve helptext for sending NFTs #29296
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
balanceColor={'textColor' as TextColor} | ||
/> | ||
</Provider>, | ||
const { asFragment } = renderWithProvider( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using renderWithProvider
to access I18nProvider
8fdd356
to
1599efc
Compare
1599efc
to
74d2722
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
- checked sending single NFT ✅
- checked insufficient balance error message ✅
- did not check multiple NFTs
Builds ready [74d2722]
Page Load Metrics (1746 ± 68 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@georgewrmarshall thanks for checking ! i didn't find a way to send multiple nfts, but i used unit tests to cover the case to validate the content 🙌🏻 |
Description
Helper text for sending NFTs to another address is not accurate. We got feedback from design to implement the following:
Related issues
Fixes: #26772
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist