fix: increase gas limit validation threshold

[vinistevam]

Description

This PR aims to increase the gas limit validation threshold to 30M.

Related issues

Fixes: #21927

Manual testing steps

1. send a transaction
2. edit gaslimit on advance tab

Screenshots/Recordings

Screencast.from.17-12-2024.08.51.19.webm

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [5a837f0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1666 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1533	1858	1666	85	41
		domContentLoaded	1517	1839	1636	87	42
		load	1532	1863	1666	86	41
		domInteractive	25	164	42	32	15
		backgroundConnect	10	139	32	31	15
		firstReactRender	16	98	48	30	14
		getState	5	69	13	16	8
		initialActions	0	1	0	0	0
		loadScripts	1132	1340	1228	60	29
		setupStore	6	77	18	20	10
		uiStartup	1779	2370	1994	201	97

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 1 Bytes (0.00%)

[pedronfigueiredo]

isn't the lower limit 20999?

[vinistevam]

yeah I also tried to fix that and got stuck until I realised that we have an error logic where we use editGasLimitOutOfBoundsV2 which accepts two values so in the mocking data we are sending originalGasEstimate: '0x78D9B2' (30000) and there is this logic here changing the min to 29999.

[metamaskbot]

Builds ready [ecca93f]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1796 ± 160 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1465	2937	1800	338	162
		domContentLoaded	1412	2909	1770	342	164
		load	1467	2919	1796	333	160
		domInteractive	23	189	56	44	21
		backgroundConnect	8	57	24	13	6
		firstReactRender	16	103	33	27	13
		getState	5	85	29	25	12
		initialActions	0	1	0	0	0
		loadScripts	1026	2376	1337	304	146
		setupStore	7	61	19	18	9
		uiStartup	1671	3296	2063	402	193

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 1 Bytes (0.00%)

[metamaskbot]

Builds ready [1480430]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1689 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	219	1930	1555	454	218
		domContentLoaded	1417	1921	1671	146	70
		load	1430	1981	1689	151	73
		domInteractive	24	108	38	19	9
		backgroundConnect	7	66	20	17	8
		firstReactRender	15	102	44	28	14
		getState	5	96	19	25	12
		initialActions	0	1	0	0	0
		loadScripts	1017	1432	1220	128	61
		setupStore	6	86	20	25	12
		uiStartup	1669	2625	1999	248	119

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 1 Bytes (0.00%)