fix: Return to send page with different asset types

[pedronfigueiredo]

Description

This bug was reproducible by opening a new wallet initiated send confirmation with a Native token ("simple send") from the extension full screen view, and then triggering a dApp initiated confirmation, and trying to return back to the send flow stepper.

The bug was provoked due to having the editExistingTransaction action dispatched on back button click hardcoded for asset of type token. The fix involves dynamically determining the asset type.

Related issues

Fixes: #28316

Manual testing steps

See above or check video on the bug report ticket.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [e729514]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1899 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1654	2352	1900	200	96
		domContentLoaded	1611	2279	1869	197	95
		load	1653	2352	1899	201	97
		domInteractive	20	79	47	15	7
		backgroundConnect	8	81	33	24	12
		firstReactRender	66	164	103	23	11
		getState	4	55	14	15	7
		initialActions	0	0	0	0	0
		loadScripts	1181	1719	1382	159	76
		setupStore	6	60	12	15	7
		uiStartup	1796	2515	2117	224	108

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 430 Bytes (0.01%)
• common: 0 Bytes (0.00%)

[matthewwalsh0]

Minor, if these booleans only exist to support the if below, would it be cleaner to use a switch:

let assetType: AssetType;

switch(currentConfirmation.type) {
    case TransactionType.simpleSend:
        assetType = AssetType.native;
        break;

    ...

    case TransactionType.tokenMethodTransferFrom:
    case TransactionType.tokenMethodSafeTransferFrom:
        assetType = AssetType.NFT;
        break;

   default:
       assetType = AssetType.unknown;
       break;
}

[jpuri]

Will be nice to test cover also, may be in following PR.