Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable buy for btc testnet accounts #28341

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

montelaidev
Copy link
Contributor

Description

This PR disables the Buy / sell button for btc testnet accounts

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/655

Manual testing steps

  1. Create a testnet btc account
  2. Go to the overview page
  3. See that the buy/sell button is disabled.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev force-pushed the fix/disable-swaps-for-btc-testnet-accounts branch from 90c2cca to 8908e36 Compare November 7, 2024 13:12
@montelaidev montelaidev marked this pull request as ready for review November 7, 2024 13:19
@montelaidev montelaidev requested a review from a team as a code owner November 7, 2024 13:19
@metamaskbot
Copy link
Collaborator

Builds ready [8908e36]
Page Load Metrics (2331 ± 137 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint76031912247441212
domContentLoaded187531682294296142
load193731852331286137
domInteractive217953178
backgroundConnect6111403115
firstReactRender542041273919
getState564292110
initialActions00000
loadScripts137122381701224108
setupStore1281362311
uiStartup222635872639307148
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 347 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@ccharly ccharly added this pull request to the merge queue Nov 8, 2024
Merged via the queue into develop with commit 1d4fcc0 Nov 8, 2024
76 checks passed
@ccharly ccharly deleted the fix/disable-swaps-for-btc-testnet-accounts branch November 8, 2024 11:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants