-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add account_type
/snap_id
for buy/send metrics
#28011
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3bc328d
to
7453ec4
Compare
Builds ready [7453ec4]
Page Load Metrics (1944 ± 59 ms)
Bundle size diffs
|
account_type
/snap_id
for buy/send metrics
danroc
reviewed
Nov 8, 2024
danroc
reviewed
Nov 8, 2024
danroc
reviewed
Nov 8, 2024
9909ea6
to
8fcb580
Compare
8fcb580
to
86e82ee
Compare
86e82ee
to
1a76031
Compare
91c169c
to
0e7dae1
Compare
Builds ready [0e7dae1]
Page Load Metrics (1750 ± 78 ms)
Bundle size diffs
|
danroc
reviewed
Nov 9, 2024
danroc
approved these changes
Nov 12, 2024
gantunesr
approved these changes
Nov 12, 2024
Builds ready [d890d17]
Page Load Metrics (1850 ± 62 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more context/info to the Send/Buy events for both Ethereum and Bitcoin overview screens.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/636, https://github.com/MetaMask/accounts-planning/issues/637
Manual testing steps
node development/mock-segment.js -v
yarn start:flask
You should see those events from the
mock-segment.js
server output:Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist