Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset nonce as network is switched #27789

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 11, 2024

Description

Fix issue with nonce being not reset when switching network.

Related issues

Fixes: #27788

Manual testing steps

  1. Go to test dapp
  2. Switch network between submitting transactions
  3. Ensure that nonce is correct each time

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 11, 2024
@jpuri jpuri requested a review from a team as a code owner October 11, 2024 10:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4bb636f]
Page Load Metrics (2055 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36524671864544261
domContentLoaded163023972010227109
load166624652055241116
domInteractive25170523115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 57 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [4d151f4]
Page Load Metrics (1744 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32219111529500240
domContentLoaded1550185317188340
load1561186217449043
domInteractive148240189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 57 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri enabled auto-merge October 14, 2024 14:05
Copy link

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@jpuri jpuri removed this pull request from the merge queue due to a manual request Oct 15, 2024
Copy link

@jpuri jpuri enabled auto-merge October 15, 2024 13:07
@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [72cef13]
Page Load Metrics (1743 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28022731622430206
domContentLoaded15162176169913565
load15202284174315474
domInteractive238943199

Merged via the queue into develop with commit f880da8 Oct 15, 2024
78 checks passed
@jpuri jpuri deleted the network_switch_nonce_fix branch October 15, 2024 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 15, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nonce does not update if we switch network between transactions
6 participants