Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(3212): remove alert settings #27709

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Oct 8, 2024

Description

This PR removes the "Alerts" section from the Extension's Settings menu, preparing for future updates. The two settings previously offered here, unconnectedAccount and web3ShimUsage, are no longer configurable and will remain toggled on by default. All related UI elements and tests have been removed.

Rationale for removal:

  • unconnectedAccount: This feature, which alerts users when browsing a website with an unconnected account selected, is now considered a core functionality that doesn't require user configuration.
  • web3ShimUsage: This setting was introduced to inform users why a dapp might be broken due to using the deprecated window.web3 API. However, current data shows limited usage, primarily from non-crypto sites, and the
    warning only displays for connected dapps, limiting its effectiveness.

This change paves the way for repurposing the bell icon for a new Notifications feature. Testing confirms that this removal doesn't affect other parts of the extension, and all remaining tests pass successfully.

Note: Controller/state related removal will be addressed in a separate pull request and tracked in a separate issue.

Open in GitHub Codespaces

Related issues

Fixes: #3212

Manual testing steps

  1. Goto settings page by clicking on the more icon which are the three dots in the top right corner, and then click on settings.
  2. Check to see if the "Alerts" settings are gone
  3. Search for "Alerts" in the settings search and make sure nothing appears other than "Security & Privacy > Security Alerts" which is unrelated to the "Alerts" section being removed

Screenshots/Recordings

NA

Before

Menu

before_menu

Search

before_search

After

Menu

after_menu

Search

after_search

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward changed the title chore: remove alert settings chore(27709): remove alert settings Oct 8, 2024
@vinnyhoward vinnyhoward changed the title chore(27709): remove alert settings chore(3212): remove alert settings Oct 8, 2024
Copy link

sonarqubecloud bot commented Oct 8, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [6949e85]
Page Load Metrics (1872 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15912274187619091
domContentLoaded15492253184718388
load15572269187219594
domInteractive278043178
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -4.86 KiB (-0.06%)
  • common: -646 Bytes (-0.01%)

Copy link
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@vinnyhoward vinnyhoward added this pull request to the merge queue Oct 10, 2024
Merged via the queue into develop with commit 0798717 Oct 10, 2024
84 checks passed
@vinnyhoward vinnyhoward deleted the chore-3212-alert-settings-removal branch October 10, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 10, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants