-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(3212): remove alert settings #27709
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Builds ready [6949e85]
Page Load Metrics (1872 ± 94 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Description
This PR removes the "Alerts" section from the Extension's Settings menu, preparing for future updates. The two settings previously offered here,
unconnectedAccount
andweb3ShimUsage
, are no longer configurable and will remain toggled on by default. All related UI elements and tests have been removed.Rationale for removal:
unconnectedAccount
: This feature, which alerts users when browsing a website with an unconnected account selected, is now considered a core functionality that doesn't require user configuration.web3ShimUsage
: This setting was introduced to inform users why a dapp might be broken due to using the deprecated window.web3 API. However, current data shows limited usage, primarily from non-crypto sites, and thewarning only displays for connected dapps, limiting its effectiveness.
This change paves the way for repurposing the bell icon for a new Notifications feature. Testing confirms that this removal doesn't affect other parts of the extension, and all remaining tests pass successfully.
Note: Controller/state related removal will be addressed in a separate pull request and tracked in a separate issue.
Related issues
Fixes: #3212
Manual testing steps
Screenshots/Recordings
NA
Before
Menu
Search
After
Menu
Search
Pre-merge author checklist
Pre-merge reviewer checklist