-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add transaction flow and details sections #27654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
c93e4c4
to
ab43b86
Compare
matthewwalsh0
requested changes
Oct 7, 2024
ui/pages/confirmations/components/confirm/info/hooks/use-token-values.ts
Outdated
Show resolved
Hide resolved
f581e9c
to
ef4b230
Compare
8f29230
to
bdddb4f
Compare
34f2b40
to
2203d10
Compare
7 tasks
dc9604c
to
a666b99
Compare
f02f9de
to
d624dcb
Compare
matthewwalsh0
requested changes
Oct 16, 2024
ui/pages/confirmations/components/confirm/info/token-transfer/token-transfer.tsx
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/token-transfer/token-details-section.tsx
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/token-transfer/name-or-address-display.tsx
Outdated
Show resolved
Hide resolved
1f20c44
to
181634e
Compare
matthewwalsh0
previously approved these changes
Oct 16, 2024
181634e
to
ef2385a
Compare
vinistevam
previously approved these changes
Oct 16, 2024
ef2385a
to
51c9b16
Compare
Builds ready [5cd1c40]
Page Load Metrics (1704 ± 110 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
99d0ce3
to
147e2d9
Compare
vinistevam
previously approved these changes
Oct 17, 2024
147e2d9
to
3d5e95a
Compare
vinistevam
approved these changes
Oct 17, 2024
Builds ready [3d5e95a]
Page Load Metrics (1947 ± 122 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
approved these changes
Oct 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two new sections for the wallet initiated ERC20 token transfer redesigned confirmation.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3220
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist