Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Snaps packages #27376

Merged
merged 16 commits into from
Oct 16, 2024
Merged

chore: Bump Snaps packages #27376

merged 16 commits into from
Oct 16, 2024

Commits on Oct 15, 2024

  1. Bump Snaps packages

    Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d4646ac View commit details
    Browse the repository at this point in the history
  2. Bump dependencies again

    Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f80b898 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9aef087 View commit details
    Browse the repository at this point in the history
  4. feat: Integrate MetaMask links into Snaps Link component (#27377)

    ## **Description**
    
    
    Write a short description of the changes included in this pull request,
    also include relevant motivation and context. Have in mind the following
    questions:
    1. What is the reason for the change? Previously, developers couldn't
    navigate to parts of the extension with the existing functionality
    provided to them through snaps UI
    2. What is the improvement/solution? The Snaps `Link` component now
    checks for if the url is a MetaMask url and navigates to the proper path
    accordingly.
    
    
    ## **Screenshots/Recordings**
    
    ### **After**
    
    
    ## **Pre-merge author checklist**
    
    - [ ] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    hmalik88 authored and Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    da49f89 View commit details
    Browse the repository at this point in the history
  5. update yarn.lock

    hmalik88 authored and Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    bf461e7 View commit details
    Browse the repository at this point in the history
  6. dedupe

    hmalik88 authored and Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    cd33dd2 View commit details
    Browse the repository at this point in the history
  7. Bump dependencies again again

    Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8639215 View commit details
    Browse the repository at this point in the history
  8. Bump execution environment URL

    Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fed904b View commit details
    Browse the repository at this point in the history
  9. feat(snaps): Add size prop to Heading (#27721)

    ## **Description
    
    This PR adds support for the `size` prop to the `Heading` component.
    Right now `md` is bind to `headingMd`, `lg` is bind to `headingLg` to
    match
    https://www.figma.com/design/2cqqTWJKoHcjYVGfNXxLbQ/Beyond-Ethereum?node-id=3458-5041&node-type=text&m=dev
    as requested by @eriknson. The default behavior if `size` is not defined
    si `headingSm`
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27721?quickstart=1)
    
    ## **Related issues**
    
    ## **Manual testing steps**
    
    ## **Pre-merge author checklist**
    
    - [ ] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    GuillaumeRx authored and Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    16edc50 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7948adb View commit details
    Browse the repository at this point in the history
  11. feat(snaps): Add min, max and step to Snap UI input (#27822)

    ## **Description**
    
    This adds the `min`, `max` and `step` props to the `Input` component of
    Snaps custom UI.
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27822?quickstart=1)
    
    ## **Related issues**
    
    ## **Manual testing steps**
    
    ## **Screenshots/Recordings**
    
    
    ## **Pre-merge author checklist**
    
    - [ ] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    GuillaumeRx authored and Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1ccd899 View commit details
    Browse the repository at this point in the history
  12. feat(snaps): Add sm variant to Heading size prop (#27823)

    ## **Description**
    
    This PR adds a case for the `sm` variant of the `size` prop in the
    `Heading` Snaps custom UI component.
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27823?quickstart=1)
    
    ## **Related issues**
    
    ## **Manual testing steps**
    
    ## **Screenshots/Recordings**
    
    ## **Pre-merge author checklist**
    
    - [ ] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    
    ---------
    
    Co-authored-by: Hassan Malik <[email protected]>
    2 people authored and Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fdaa1f4 View commit details
    Browse the repository at this point in the history
  13. feat: Add Snap UI avatar component (#27826)

    <!--
    Please submit this PR as a draft initially.
    Do not mark it as "Ready for review" until the template has been
    completely filled out, and PR status checks have passed at least once.
    -->
    
    ## **Description**
    
    Move Snaps UI avatar implementation to a separate component that can be
    consumed by Snaps.
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27826?quickstart=1)
    
    ## **Related issues**
    
    Closes: MetaMask/snaps#2776
    
    ## **Manual testing steps**
    ```jsx
    export const onRpcRequest: OnRpcRequestHandler = async ({
      origin,
      request,
    }) => {
      switch (request.method) {
        case 'hello':
          return snap.request({
            method: 'snap_dialog',
            params: {
              type: 'confirmation',
              content: (
                <Box>
                  <Text>
                    Hello, <Bold>{origin}</Bold>!
                  </Text>
                  <Text>
                    This custom confirmation is just for display purposes.
                  </Text>
                  <Text>
                    But you can edit the snap source code to make it do something,
                    if you want to!
                  </Text>
                  <Address address='eip155:1:0x1234567890123456789012345678901234567890' />
                  <Avatar address="eip155:1:0x1234567890123456789012345678901234567890" />
                  <Address address="bip122:000000000019d6689c085ae165831e93:128Lkh3S7CkDTBZ8W7BbpsN3YYizJMp8p6" />
                  <Avatar address="bip122:000000000019d6689c085ae165831e93:128Lkh3S7CkDTBZ8W7BbpsN3YYizJMp8p6" />
                  <Box direction="horizontal" alignment="space-between" center={true}>
                    <Text>Avatar</Text>
                    <Avatar address="bip122:000000000019d6689c085ae165831e93:128Lkh3S7CkDTBZ8W7BbpsN3YYizJMp8p6" />
                  </Box>
     
                </Box>
              ),
            },
          });
        default:
          throw new Error('Method not found.');
      }
    };
    
    ```
    
    ## **Screenshots/Recordings**
    
    <img width="387" alt="Screenshot 2024-10-14 at 14 44 50"
    src="https://github.com/user-attachments/assets/e06a0aca-0aeb-4004-9290-d700867b4eff">
    FrederikBolding authored and Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d1a2e6e View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e0341f9 View commit details
    Browse the repository at this point in the history
  15. fix(snaps): Fix types on custom UI Input (#27860)

    ## **Description**
    
    This PR fixes a type issue on custom UI `Input` component.
    
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27860?quickstart=1)
    
    ## **Related issues**
    
    ## **Manual testing steps**
    
    ## **Screenshots/Recordings**
    
    ## **Pre-merge author checklist**
    
    - [ ] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    GuillaumeRx authored and Mrtenz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7598b3a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    a756f10 View commit details
    Browse the repository at this point in the history