fix: remove methods from array used to determine which requests should be enqueued because they can be safely passed through

[adonesky1]

Description

Fix issues that arise when a STX is initated in a dapp and subsequent method calls were being unnecessarily queued until the STX was complete.

The following methods can be safely removed from the list of methods we use to determine whether a request should be queued or executed immediately:

• 'wallet_addEthereumChain'
• 'wallet_requestPermissions',
• 'wallet_requestSnaps',
• 'eth_decrypt',
• 'eth_requestAccounts',
• 'eth_getEncryptionPublicKey',

Related issues

Fixes: #27098

Manual testing steps

1. Make sure you have STX enabled from settings
2. Navigate to https://docs.metamask.io/wallet/reference/eth_sendtransaction/
3. Connect the wallet and switch networks to Sepolia
4. Trigger a TX (call run request)
5. Confirm the transaction and see the STX pending screen
6. Go to test dapp
7. Click Connect --> this needs to happen while STX is pending
8. See that you are able to connect

Screenshots/Recordings

Before

Before-wallet_requestSnaps.mov

After

wallet_requestPermissions:

Screen.Recording.2024-09-20.at.1.11.57.PM.mov

wallet_requestSnaps

Screen.Recording.2024-09-20.at.1.41.04.PM.mov

eth_requestAccounts

Screen.Recording.2024-09-20.at.1.14.44.PM.mov

wallet_addEthereumChain

Screen.Recording.2024-09-20.at.1.01.45.PM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[jiexi]

LGTM after the eth_accounts special handling is removed from shouldEnqueueRequest

[dbrans]

@adonesky1, fantastic investigation and documentation of the changes!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [e7d6712]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1858 ± 122 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	566	2702	1795	375	180
		domContentLoaded	1555	2519	1802	216	104
		load	1563	2725	1858	254	122
		domInteractive	15	67	32	18	9

Bundle size diffs [🚀 Bundle size reduced!]

• background: -322 Bytes (-0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Missing release label release-12.3.0 on PR. Adding release label release-12.3.0 on PR and removing other release labels(release-12.6.0), as PR was cherry-picked in branch 12.3.0.