Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick][V12.3.0] fix: PermitTransferFrom or PermitBatchTransferFrom crashes MM when value for Name address has not been loaded #27168

Merged

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Sep 16, 2024

Description

cherry-picks #26791 into V12.3.0

no conflicts

Open in GitHub Codespaces

Related issues

Fixes: #26593

V12.3.0 cherry-pick Fixes: #26830

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner September 16, 2024 13:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [5707d88]
Page Load Metrics (1983 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29426241768632303
domContentLoaded15672340196120599
load158023731983212102
domInteractive217341167

@digiwand digiwand added team-confirmations Push issues to confirmations team release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Sep 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5942555]
Page Load Metrics (2103 ± 136 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30826191823683328
domContentLoaded172626592066286137
load173726702103283136
domInteractive15115462613

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.25%. Comparing base (439f7d6) to head (5942555).
Report is 4 commits behind head on Version-v12.3.0.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.3.0   #27168      +/-   ##
===================================================
+ Coverage            70.24%   70.25%   +0.01%     
===================================================
  Files                 1426     1427       +1     
  Lines                50239    50260      +21     
  Branches             13954    13963       +9     
===================================================
+ Hits                 35289    35310      +21     
  Misses               14950    14950              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danjm danjm merged commit ad728f7 into Version-v12.3.0 Sep 16, 2024
72 checks passed
@danjm danjm deleted the cherry-pick-12.3.0-fix-confirm-name-no-0x-prefix-value branch September 16, 2024 18:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
@digiwand digiwand changed the title fix: cherry-pick V12.3.0 fix: PermitTransferFrom or PermitBatchTransferFrom crashes MM when value for Name address has not been loaded fix: [cherry-pick][V12.3.0] fix: PermitTransferFrom or PermitBatchTransferFrom crashes MM when value for Name address has not been loaded Sep 18, 2024
@digiwand digiwand linked an issue Sep 24, 2024 that may be closed by this pull request
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cherry-pick PRs for 12.3.0 (including formal 12.4.0 PRs)
4 participants