fix: check if the notifications started flow is running #27038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matteoscurati
changed the title
Builds ready [dc4cfd5]
Page Load Metrics (1687 ± 75 ms)
Bundle size diffs
|
Prithpal-Sooriya
previously approved these changes
Sep 10, 2024
mathieuartu
previously approved these changes
Sep 10, 2024
Builds ready [614e557]
Page Load Metrics (1933 ± 79 ms)
Bundle size diffs
|
matteoscurati
dismissed stale reviews from mathieuartu and Prithpal-Sooriya
via
0491e5f
Builds ready [e7341cb]
Page Load Metrics (1758 ± 55 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #27038 +/- ##
===========================================
- Coverage 70.15% 70.15% -0.00%
===========================================
Files 1425 1425
Lines 49653 49656 +3
Branches 13891 13892 +1
===========================================
Hits 34833 34833
- Misses 14820 14823 +3 ☔ View full report in Codecov by Sentry. |
mathieuartu
reviewed
Sep 11, 2024
| @@ -51,14 +51,14 @@ export default function TurnOnMetamaskNotifications() { | |||
| ); | |||
| const isProfileSyncingEnabled = useSelector(selectIsProfileSyncingEnabled); | |||
|
|
|||
| const [buttonState, setButtonState] = useState<boolean>( | |||
| const [loadingState, setLoadingState] = useState<boolean>( | |||
There was a problem hiding this comment.
I'm always a bit more in favor of "boolean" names, like [isLoading, setIsLoading], wdyt?
There was a problem hiding this comment.
Yep, you are right. I was a bit lazy :)
|
Builds ready [5e081d2]
Page Load Metrics (1788 ± 75 ms)
Bundle size diffs
|
Prithpal-Sooriya
approved these changes
Sep 11, 2024
metamaskbot
added
release-12.6.0
|
Missing release label release-12.3.0 on PR. Adding release label release-12.3.0 on PR and removing other release labels(release-12.6.0), as PR was cherry-picked in branch 12.3.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check to the modal for enabling notifications. If the enabling process is in progress, closing the modal does not trigger the “dismissed” event.
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist