Update assets controllers to version 16

[pedronfigueiredo]

Description

Updates assets controllers on the extension to the latest version.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@metamask/network-controller	14.0.0	None	+0	219 kB	metamaskbot
@babel/preset-env	7.23.2	environment	+0	141 kB	nicolo-ribaudo
@metamask/assets-controllers	13.0.0...16.0.0	None	+6/-1	1.22 MB	metamaskbot

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

[legobeat]

@SocketSecurity ignore [email protected]

[legobeat]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[jiexi]

there are breaking changes that need to be adopted

https://github.com/MetaMask/core/blob/main/packages/assets-controllers/CHANGELOG.md

[metamaskbot]

Policies updated

[adonesky1]

Yeah I can add a commit to make some of the adaptations on Monday. About to sign off for the week.

[adonesky1]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[legobeat]

Looks like some changes are necessary after upgrade:

app/scripts/controllers/transactions/IncomingTransactionHelper.test.ts:142:48 - error TS2339: Property 'networkId' does not exist on type 'NetworkState'.

142           currentNetworkId: NETWORK_STATE_MOCK.networkId,
                                                   ~~~~~~~~~

app/scripts/controllers/transactions/IncomingTransactionHelper.ts:280:36 - error TS2339: Property 'networkId' does not exist on type 'NetworkState'.

280     return this.#getNetworkState().networkId as string;
                                       ~~~~~~~~~

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/60144/workflows/dfd963f1-31ff-45be-8fdb-39e12a92b3f5/jobs/1867947

Also needs rebase on develop.

[pedronfigueiredo]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[pedronfigueiredo]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[legobeat]

Lint passing 👍

[metamaskbot]

Builds ready [bb28cb8]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (619 ± 318 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	80	107	85	5	3
		domContentLoaded	63	104	75	11	5
		load	74	1517	619	663	318
		domInteractive	63	104	75	11	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 3.07 KiB (0.08%)
• ui: 0 Bytes (0.00%)
• common: 7.28 KiB (0.15%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (359409c) 68.57% compared to head (bb28cb8) 68.61%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #21380      +/-   ##
===========================================
+ Coverage    68.57%   68.61%   +0.03%     
===========================================
  Files         1030     1030              
  Lines        41030    41023       -7     
  Branches     10945    10946       +1     
===========================================
+ Hits         28136    28145       +9     
+ Misses       12894    12878      -16     

Files	Coverage Δ
app/scripts/metamask-controller.js	55.43% <100.00%> (+0.62%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.