Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E chunking #16653

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Fix E2E chunking #16653

merged 2 commits into from
Nov 23, 2022
+7 −5

Conversation

FrederikBolding
Copy link
Member

Explanation

Replaces the existing E2E chunking algorithm with a more sane version that guarantees the total number of chunks.

@FrederikBolding FrederikBolding marked this pull request as ready for review November 23, 2022 11:09
@FrederikBolding FrederikBolding requested a review from a team as a code owner November 23, 2022 11:09
@metamaskbot
Copy link
Collaborator

Builds ready [7c7f02a]
Page Load Metrics (2283 ± 341 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint931360233364175
domContentLoaded162946762259722347
load168746762283711341
domInteractive162946762259722347
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

Gudahtt
Gudahtt approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding FrederikBolding merged commit dd20281 into develop Nov 23, 2022
@FrederikBolding FrederikBolding deleted the fb/fix-e2e-chunking branch November 23, 2022 14:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@brad-decker brad-decker brad-decker approved these changes

@segun segun Awaiting requested review from segun segun is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrederikBolding @metamaskbot @Gudahtt @brad-decker