Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove callback from being saved in controller state #16627

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Remove callback from being saved in controller state #16627

merged 2 commits into from
Nov 23, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 22, 2022

Fixes: #16484

Remove callback from being saved in controller state.

@jpuri jpuri requested a review from a team as a code owner November 22, 2022 15:38
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [603393e]
Page Load Metrics (2941 ± 684 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9353008381547743
domContentLoaded1752553129171405675
load1752555529411424684
domInteractive1752553129171405675
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 54 bytes
  • ui: 0 bytes
  • common: 0 bytes

@danjm danjm added this to the v10.23.0 milestone Nov 22, 2022
@seaona
Copy link
Contributor

seaona commented Nov 23, 2022

I've QAd this PR and it solves indeed the FireFox issue. It works well both on Chrome (MV2+MV3) and Firefox (MV2)

Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the issue for me as well. FF x macOS

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great find!

Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpuri jpuri merged commit 82dc628 into develop Nov 23, 2022
@jpuri jpuri deleted the ff_fix branch November 23, 2022 18:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants