Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infura rpc detection #16585

Merged

Conversation

legobeat
Copy link
Contributor

Fixes the following error when trying to connect to Rinkeby:

backend.js:12979 Warning: Failed prop type: Invalid prop `showDeprecatedRpcUrlWarning` of type `array` supplied to `LoadingNetworkScreen`, expected `boolean`.
    in LoadingNetworkScreen (created by ConnectFunction)
    in ConnectFunction (created by Routes)
    in div (created by Routes)
    in div (created by Routes)
    in Routes (created by ConnectFunction)
    in ConnectFunction (created by Context.Consumer)
    in withRouter(Connect(Routes)) (created by Index)
    in LegacyI18nProvider (created by Index)
    in I18nProvider (created by Index)
    in LegacyMetaMetricsProvider (created by Index)
    in MetaMetricsProvider (created by Index)
    in Router (created by HashRouter)
    in HashRouter (created by Index)
    in Provider (created by Index)
    in Index

Also actually check the domain rather than substring inclusion on the URL.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat force-pushed the fix/deprecated-rpc-infura-detection branch 2 times, most recently from 44343ef to 941a4eb Compare November 19, 2022 01:33
@legobeat legobeat marked this pull request as ready for review November 19, 2022 02:50
@legobeat legobeat requested a review from a team as a code owner November 19, 2022 02:50
@legobeat legobeat requested a review from jpuri November 19, 2022 02:50
@legobeat legobeat force-pushed the fix/deprecated-rpc-infura-detection branch from 941a4eb to 5dfd2a6 Compare November 23, 2022 13:52
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 0e573e1 into MetaMask:develop Nov 23, 2022
@legobeat legobeat deleted the fix/deprecated-rpc-infura-detection branch November 23, 2022 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants