disabled save button on add contact form if input fields are empty #16233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [2930ab6]
Page Load Metrics (2217 ± 45 ms)
highlights: |
|
Verified by QA |
darkwing
requested changes
Oct 20, 2022
| @@ -142,7 +142,7 @@ export default class AddContact extends PureComponent { | |||
| </div> | |||
| <PageContainerFooter | |||
| cancelText={this.context.t('cancel')} | |||
| disabled={Boolean(this.state.error)} | |||
| disabled={Boolean(this.state.error || !this.state.ethAddress)} | |||
There was a problem hiding this comment.
I think we may want to move this ethAddress check to the validate method so all validation/errors are set in the same place.
There was a problem hiding this comment.
Hi @darkwing, I've tried that solution, but it didn't work well. The function validate checks only when we enter a value. In the task the button should be disabled when the field is empty. You can see the following video (when it is added in validate function)
Screen.Recording.2022-10-26.at.17.10.59.mov
darkwing
approved these changes
Nov 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Disabled save button on add contact form if input field(address) are empty.
More Information
Screenshots/Screencaps
Before
192776372-43842ec8-12cf-4466-b2fe-a87870819c35.mov
After
Screen.Recording.2022-10-19.at.13.28.40.mov
Manual Testing Steps