Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding expanse network #1555

Closed
wants to merge 1 commit into from
Closed

Adding expanse network #1555

wants to merge 1 commit into from

Conversation

chrisfranko
Copy link

No description provided.

@2-am-zzz
Copy link
Contributor

2-am-zzz commented Jun 8, 2017

Thank you for being thorough with this PR in line with the procedure to add new networks. We will have to deliberate on whether or not to add it in though, as our network menu is already getting clogged as is.

@kumavis
Copy link
Member

kumavis commented Jun 8, 2017

for relevant discussion, see #1476

@chrisfranko
Copy link
Author

Thanks, the only thing i didnt notice was setting chain_id or network_id

The chain id of EXP is 2, while our network id is 1.

A suggested change to the network menu id make is... Have ETH and EXP and but have ETH be a dropdown menu that houses all the eth networks. It would tidy it up a bit and make some room. Also, as a plan B, if yall decide against integrating EXP how much of MetaMask would I be able to rebrand as say MetaMask-EXP or something entirely different.

MetaMask is really helpful for people with little experience in crypto to be able to use dapps. (I personally use it all the time for testing the dapps we are working on at expanse)

@kumavis kumavis added the DO-NOT-MERGE Pull requests that should not be merged label Jul 13, 2017
@danfinlay danfinlay mentioned this pull request Jul 25, 2017
2 tasks
@2-am-zzz
Copy link
Contributor

Encapsulated in #1820 until we can dedicate more time to this. Please redirect all concerns to that issue.

@2-am-zzz 2-am-zzz closed this Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE Pull requests that should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants