Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contract-metadata to 1.35.0 #14785

Closed
wants to merge 1 commit into from
Closed

Conversation

danfinlay
Copy link
Contributor

@danfinlay danfinlay commented May 26, 2022

To include the top 10 NFT projects, due to current high volume of phishing.

To include the top 10 NFT projects, due to current high volume of phishing.
@danfinlay danfinlay requested a review from a team as a code owner May 26, 2022 02:04
@danfinlay danfinlay requested a review from darkwing May 26, 2022 02:04
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -114,7 +114,7 @@
"@keystonehq/bc-ur-registry-eth": "^0.6.8",
"@keystonehq/metamask-airgapped-keyring": "0.2.1",
"@material-ui/core": "^4.11.0",
"@metamask/contract-metadata": "^1.31.0",
"@metamask/contract-metadata": "1.35.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is what you meant to do?

Suggested change
"@metamask/contract-metadata": "1.35.0",
"@metamask/contract-metadata": "^1.35.0",

Making this change then running yarn yarn-deduplicate will also get rid of the 2nd copy in our dependency tree

@danfinlay
Copy link
Contributor Author

Closing in favor of #14791

@Gudahtt Gudahtt closed this May 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants