-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ethereum Classic Support #1476
Ethereum Classic Support #1476
Changes from 1 commit
1bc7c1a
b398a56
782f476
2398ea5
7b8eb42
a6d8ce8
e2d8ec3
6483d81
b0364b8
0ffd152
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -871,7 +871,8 @@ function pairUpdate (coin) { | |
} | ||
|
||
function shapeShiftSubview (network) { | ||
var pair = 'btc_eth' | ||
var pair | ||
network === 'classic' ? pair = 'btc_etc' : pair = 'btc_eth' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not a fan of having these ternary Rather than doing this custom coding by hand, it would be nicer to use a general network config file for interpreting chain data into app behavior. |
||
|
||
return (dispatch) => { | ||
dispatch(actions.showSubLoadingIndication()) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -171,6 +171,10 @@ function currentProviderDisplay (metamaskState) { | |
value = 'Rinkeby Test Network' | ||
break | ||
|
||
case 'classic': | ||
title = 'Current Network' | ||
value = 'Ethereum Classic Network' | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing break |
||
default: | ||
title = 'Current RPC' | ||
value = metamaskState.provider.rpcTarget | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RPC providers should use
https
for privacy.