Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow default network switching with addEthereumChain. #10623 #10597 #10711

Closed
wants to merge 1 commit into from
Closed

Allow default network switching with addEthereumChain. #10623 #10597 #10711

wants to merge 1 commit into from
+0 −9

Conversation

miguelmota
Copy link

Fixes: #10623 #10597

@miguelmota
Allow default network switching with addEthereumChain. MetaMask#10623 M…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a0f3d95 
…etaMask#10597
@miguelmota miguelmota requested a review from a team as a code owner March 24, 2021 20:12
@miguelmota miguelmota requested a review from ryanml March 24, 2021 20:12
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2021 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@miguelmota
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@Gudahtt
Copy link
Member

Gudahtt commented Mar 26, 2021

Thanks for the contribution! Unfortunately we're not intending to allow switching to default networks via addEthereumChain at this time. As mentioned in this comment there is another EIP in draft right now intended to allow dapps to suggest switching to any network, including default networks. We're going to implement that instead.

@Gudahtt Gudahtt closed this Mar 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanml ryanml

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addEthereumChain Remove 'May not specify default MetaMask chain' error
2 participants
@miguelmota @Gudahtt