Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Settings Menu #5790

Closed
bdresser opened this issue Nov 20, 2018 · 6 comments
Closed

Organize Settings Menu #5790

bdresser opened this issue Nov 20, 2018 · 6 comments
Assignees

Comments

@bdresser
Copy link
Contributor

bdresser commented Nov 20, 2018

It's getting busy in there!

Rough organization might be

Display

  • currency conversion
  • primary currency
  • language
  • blockies identicon

Developers

  • Download State Logs
  • Reset Account
  • Edit gas from send/confirm screens
  • Show Hex Data
  • Show conversion on testnets
  • Custom RPC fields
    • view current custom network?
  • More, as we determine what devs should be able to switch on/off

Accounts & Security

  • Privacy Mode
  • Clear Privacy Data
  • Reveal Seed Words
@bdresser
Copy link
Contributor Author

@cjeria @danfinlay any other thoughts?

@wbt
Copy link
Contributor

wbt commented Feb 1, 2019

I'd really like to be able to view (and ideally edit) settings for the currently selected network. Right now, if I've gone into Settings for a New Network/custom RPC, I can't double-check those settings (like URL or ChainID) when debugging a connection issue, and can't even fix a typo in the nickname, without just creating another new network and hoping that all the information is getting stored right. Is visibility into Network Settings something that can be included in this Issue, or does it need to be filed separately?

@bdresser
Copy link
Contributor Author

bdresser commented Feb 7, 2019

@wbt totally. We could ideally show preferences for all saved networks, allow editing, and allow adding new ones. Custom RPCs could easily be their own tab / section in a new menu. We'll see what MVP shapes up to look like.

As we continue to add specific functionality requested by developer users (like #6112) it might make sense to group these in Settings under one overall "Developer Mode" toggle. Users could then turn fine tune to their liking. Could include features in the Developers section above and some gathered under this label. Might require some notification or hook during onboarding to direct folks to this option.

@wbt
Copy link
Contributor

wbt commented Feb 8, 2019

Custom RPCs could easily be their own tab / section in a new menu.

I would definitely separate Network Settings and Metamask settings into separate screens. The Network Settings screen would be accessible from the Network dropdown, showing network settings for the currently selected network. Clicking Custom RPC in that same dropdown would pull up the same Network Settings display, but blank, and allow someone to add a new network. That would be a good place to implement other requested network options, like the block explorer.

When logged out, the Network Settings view could still be available, and functional for the blank custom RPC instance (might address issue #5606), with other networks' settings read-only plus a message "you need to log in to Metamask before you can change these settings. You can also copy these settings to a new custom network and edit them there. (Italics = link)

@wbt
Copy link
Contributor

wbt commented Feb 12, 2019

In the Network Settings screen, I would add a setting for the color, so that Custom RPC networks aren't always a white circle with a black question mark indicating something might be wrong.

@bdresser
Copy link
Contributor Author

bdresser commented Apr 1, 2019

done in #6333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@wbt @bdresser @chikeichan and others