Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomRPC settings: URL box should be on the top #5605

Closed
wbt opened this issue Oct 25, 2018 · 5 comments
Closed

CustomRPC settings: URL box should be on the top #5605

wbt opened this issue Oct 25, 2018 · 5 comments

Comments

@wbt
Copy link
Contributor

wbt commented Oct 25, 2018

Describe the bug
When connecting to a custom RPC, the first options shown, which occupy the screen real estate, are about currency conversion (or "current conversion;" see Issue #5603). However, this conversion is meaningless for private-network ETH. When someone's going in to connect to a custom RPC, the most important element for the user to enter is the URL.

To Reproduce

  1. Install MetaMask and create an account or log in to an existing install.
  2. Click on the MetaMask icon in the browser.
  3. Click the Network selector (where it might say "Main Ethereum Network" in the upper right).
  4. Click "Custom RPC" (the last item in the list).
  5. The network selector disappears and the UI changes to this:
    custom rpc editor
  6. Notice that most of the screen real estate is occupied by currency conversion and language settings. You have to scroll down further to access the "New RPC URL" box (using a scroll bar that is mostly hidden; that's issue NewUI: Custom RPC editor scroll bar mostly hidden #5604):
    new rpc url box

Expected behavior
The "New RPC URL" box is the first thing you see when entering the Custom RPC UI.

Browser details (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome 70.0.3538.77 (Official Build) (64-bit) (cohort: 70_77_Win)
  • MetaMask Version: 4.16.0
  • New / Beta UI
@bdresser
Copy link
Contributor

after #5134 is merged, we'll make sure the Custom RPC option scrolls to the proper point in settings (@alextsg @danjm)

@wbt
Copy link
Contributor Author

wbt commented Oct 25, 2018

When someone makes certain common errors in entering the URL, e.g. entering 127.0.0.1:7545 and Clicking SAVE, it looks like nothing happens. Really, an error showed up at the top of the tab in red text saying "URIs require the appropriate HTTP/HTTPS prefix." However, since the user is scrolled so far down, that error is hard to find.

Putting the "New RPC URL" box (UI element where users are most likely to enter erroneous input) at the top of the list would also put it closer to that error message and make the mistake easier to debug. Scrolling halfway down by default when the tab is opened would not fix that (and would be inconsistent with users' mental models from most other UIs).

@whymarrh
Copy link
Contributor

I think we can close this in favour of #5790, if you want to chime in over there. (Thoughts @bdresser?)

@wbt
Copy link
Contributor Author

wbt commented Feb 12, 2019

I have chimed in over there and if this comment were implemented, that would address this Issue too. However, I have seen too many cases in which A was closed as a duplicate in favor of/covered by the description of issue B, but then plans to address issue B changed in a way that left issue A unaddressed and closed complete. I would strongly prefer to leave this Issue open until the fix is actually in and the Expected Behavior is observed.

@bdresser
Copy link
Contributor

resolved in #6490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants