-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Gas Controls #4789
Comments
@cjeria I just wanted to say that I love this. |
I second @brunobar79 😸
|
love this + some thoughts: |
Reworked the speed up components a bit here and made two options. Left option is Time focused and right is Price focused. Updated the labeling per options as well. @bdresser @snreynolds Thoughts? |
I actually like the initial version with Cheap / Average / Fast. Including the price makes it obvious that speed costs more, and there's something good about any choice. I do like this visual treatment, sneakily adding in the new typeface 😉 On the extension-sized Confirm screen, I'm assuming the "Advanced options" opens right to the graph? Could you mock what this would look like? We may have to make some adjustments for size. |
If I click "edit" from the Confirm screen, what edit view do I see? |
Since it's ETH being sent/spent and the USD is just an estimated description, the primary really needs to be Eth (or the token being sent/spent)with any meta descriptions placed below at a smaller size. As is, it looks like you're spending USD to speed up transactions, and the eth amount is just an fyi. |
@kingjacob check out #4510 and #4804 |
Based on our twitter poll, option A is the preferred design with some minor tweaks to be made:
Link to poll:https://twitter.com/cjeria/status/1027710558785613824 Poll results:Notable feedback from the community:"1) explain why: state that the network is slow which is why you’re asking "I’m a big fan of option A, mostly because the emphasis is put on time rather than price. I also feel that as a new user it may not be apparent that low means a slow transaction and high means a fast transaction." "A. but reversed ordering or the “optimal” choice selected. Let the user know what metamask would do cause they trust you." I'd say A, but two thoughts: 1) the current time format is a bit ambiguous, e.g. unclear if it's 8 hr 25 min or 8 min 25 sec, and 2) the font size of the price seems a little small" "Like option A, but an “Advanced” option with a slider would be nice :)" |
Good feedback from the crowd, liking the input. The word "slowest" feels like the odd man out. If we're just talking about the "speed up" component, I would think they should all be some form of fast -- like, "fast / faster / fastest" (which I think you were going for with the arrows.) Also @alextsg or @danjm how are we going to estimate these? Will we suggest proportionally higher gas, or aim for a set of estimated times? |
@bdresser Our intention was to follow the recommendation scheme of ethgasstation: https://ethgasstation.info/gasrecs.php Unless @danfinlay has other thoughts on what sort of gas estimates will allow for the best UX (I know this is something Dan has spoken to during number of design syncs... although I don't know if any of us have come to any final conclusions) |
@danjm what if Will we use the same API for the user's original gas options? (aka MetaMask/Design#37) |
@cjeria These look great. One comment: when opening the modal from the confirm screen, we need to give the user access to both the basic tab and the advanced tab. So, we need to give the user a way to switch between tabs. |
@danfinlay @danjm Posting for feedback on the tabbed gas dialog |
Cool, and maybe add style for the line when a cursor is hovering over the graph? |
@bdresser We have everything we need. Thanks! |
And great work @cjeria! |
It's currently difficult to make an informed decision on what gas to set your transactions to. So we've designed better gas controls that can be used in two areas of the app.
1 - Speeding up a "slow" transaction
2 - Sending ETH
Speed up a slow transaction
Send ETH
Related design issue:
MetaMask/Design#25
The text was updated successfully, but these errors were encountered: