Skip to content
This repository was archived by the owner on May 12, 2022. It is now read-only.

Send page Transaction Fee feedback #37

Closed
alextsg opened this issue Jul 25, 2018 · 3 comments
Closed

Send page Transaction Fee feedback #37

alextsg opened this issue Jul 25, 2018 · 3 comments

Comments

@alextsg
Copy link

alextsg commented Jul 25, 2018

image

  • There may not be enough room to display the prices for different currencies, so I think we're going with a design similar to:
    image
    Can we get a mockup with our UI styles?

  • If the user clicks "Advanced options" to enter the speed up modal, manually enters in a new gas price, then returns back to the send screen, how do we represent the new custom value in the send screen since it wouldn’t be one of the 3 options?

  • If the user enters in a new value via "Advanced options", then decides he wants to go back to one of the pre-set options, how does he do that?

  • If there is an error with the API/request and we are unable to retrieve the 3 values for the options, what is the fallback? Show the current design?
    image

@cjeria
Copy link
Contributor

cjeria commented Aug 16, 2018

Here's a slight enhancement to the gas component and the basic flow/logic.

image

If there is an error with the API/request and we are unable to retrieve the 3 values for the options, what is the fallback? Show the current design?

Let's fall back to this component. I intentionally omitted the lever icon to be more explicit with copy "Advanced options"
image

Other thoughts:

  • I'm tempted to experiment with putting the gas selection in a second step in the flow gas is becoming an important step in the send flow and we'll be able to use this nicer component.

image

Thoughts?

@bdresser
Copy link

@cjeria let's start with the first option to get this out with minimal changes to what Kyokan already has - then we can think about breaking this out into its own step as the next iteration

@bdresser
Copy link

Closing this as part of MetaMask/metamask-extension#4789

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants