Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should display values of EIP712 typed boolean fields in the signing prompt #4639

Closed
weijiekoh opened this issue Jun 22, 2018 · 3 comments · Fixed by #10048
Closed

Should display values of EIP712 typed boolean fields in the signing prompt #4639

weijiekoh opened this issue Jun 22, 2018 · 3 comments · Fixed by #10048
Labels
needs-reproduction Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug

Comments

@weijiekoh
Copy link
Contributor

Expected Behavior
When MetaMask prompts the user to sign EIP-712 typed data, the preview of said data should display values of boolean fields if provided.

Actual Behavior
A blank space where one might expect to see "true" or "false". See the screenshot below.

Here is a demo of the bug in action: https://weijiekoh.github.io/js-eth-personal-sign-examples/index.html

This happens in the Beta UI as well as the regular UI.

Browser Used
Chrome 67

Operating System Used
Ubuntu Linux

Screenshots
@weijiekoh
Copy link
Contributor Author

weijiekoh commented Jun 22, 2018 •
edited
Loading

The issue on Firefox 60 with the non-beta UI:

@weijiekoh weijiekoh mentioned this issue Jun 22, 2018
Merged
@weijiekoh
Copy link
Contributor Author

Fixed with this PR: #4640

danjm added a commit that referenced this issue Jun 29, 2018
@danjm
Merge pull request #4640 from weijiekoh/develop
22debbf 
Fix for #4639: display values of EIP712 typed boolean fields in the signing prompt
@bdresser bdresser closed this as completed Jul 9, 2018
@Gudahtt
Copy link
Member

Gudahtt commented Aug 6, 2020

There has been a report that this has regressed: #4640 (comment)

@Gudahtt Gudahtt reopened this Aug 6, 2020
@Gudahtt Gudahtt added needs-reproduction Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug labels Aug 6, 2020
@nlordell nlordell mentioned this issue Dec 10, 2020
Merged
@Gudahtt Gudahtt mentioned this issue Jan 8, 2021
Closed
This was referenced Jan 20, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-reproduction Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display boolean values when signing typed data
3 participants
@bdresser @Gudahtt @weijiekoh