Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Importing token fails although it says it succeeds #23526

Closed
davibroc opened this issue Mar 15, 2024 · 3 comments
Closed

[Bug]: Importing token fails although it says it succeeds #23526

davibroc opened this issue Mar 15, 2024 · 3 comments
Assignees
@bergeron
Labels
needs-triage Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-assets type-bug

Comments

@davibroc
Copy link
Contributor

Describe the bug

When I see a message that tokens have been found in my account and click on Import I get a notification that it succeeds but I don't see the tokens in my wallet. And the message that I have tokens to import doesn't clear

See video

Expected behavior

Token are imported succesfully

Screenshots/Recordings

ImportToken.mov

Steps to reproduce

  1. Open Metamask using an account that has tokens to import
  2. Click on Import tokens
  3. Notice that the it shows it was imported successfully but tokens still not imported

Error messages or log output

No response

Version

develop

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Mar 15, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Mar 15, 2024
@davibroc davibroc reopened this Mar 15, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by severity Mar 15, 2024
@davibroc davibroc changed the title [Bug]: Importing token fails to import token although it says it succeeds [Bug]: Importing token fails although it says it succeeds Mar 20, 2024
@gauthierpetetin gauthierpetetin added team-assets Sev2-normal Normal severity; minor loss of service or inconvenience. labels Mar 21, 2024
@bergeron bergeron self-assigned this Mar 21, 2024
@bergeron bergeron mentioned this issue Mar 29, 2024
Merged
7 tasks
bergeron added a commit that referenced this issue Apr 5, 2024
@bergeron
fix: token detection and import (#23798)
f327149 
## **Description**

Fixes issues with detecting and manually importing tokens, caused by
recent controller changes.

Hotfix for 11.14.0

This state publish had an undefined variable, and had the wrong function
signature:

<img width="597" alt="Screenshot 2024-03-28 at 6 04 41 PM"
src="https://github.com/MetaMask/metamask-extension/assets/3500406/15cd8341-725b-49d8-bd4d-bf8539185214">

Which prevented the controllers from processing account switches.

A test was failing because RPC requests were sent before onboarding.
Delayed the enabling of token detection controller to
`triggerNetworkrequests`.


Also patching this fix for detection during account switch on mainnet
when autodetection=off:
MetaMask/core#4133

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/23798?quickstart=1)


## **Related issues**

Fixes:
- #23526
- #23612


## **Manual testing steps**


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
bergeron added a commit that referenced this issue Apr 5, 2024
@bergeron
fix: token detection and import (#23798)
3e5ce75 
## **Description**

Fixes issues with detecting and manually importing tokens, caused by
recent controller changes.

Hotfix for 11.14.0

This state publish had an undefined variable, and had the wrong function
signature:

<img width="597" alt="Screenshot 2024-03-28 at 6 04 41 PM"
src="https://github.com/MetaMask/metamask-extension/assets/3500406/15cd8341-725b-49d8-bd4d-bf8539185214">

Which prevented the controllers from processing account switches.

A test was failing because RPC requests were sent before onboarding.
Delayed the enabling of token detection controller to
`triggerNetworkrequests`.


Also patching this fix for detection during account switch on mainnet
when autodetection=off:
MetaMask/core#4133

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/23798?quickstart=1)


## **Related issues**

Fixes:
- #23526
- #23612


## **Manual testing steps**


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 9, 2024
@bergeron
Copy link
Contributor

bergeron commented Apr 9, 2024

Should be fixed by #23798 and cherry picked to 11.14 in #23871

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bergeron bergeron

Labels
needs-triage Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-assets type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bergeron @davibroc @gauthierpetetin