Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Copying addresses to clipboard is not working #19548

Closed
seaona opened this issue Jun 9, 2023 · 11 comments · Fixed by #19948 or #20008
Closed

[Bug]: Copying addresses to clipboard is not working #19548

seaona opened this issue Jun 9, 2023 · 11 comments · Fixed by #19948 or #20008
Assignees
Labels
CS-reported issues reported by CS CS-tracking issues being tracked by / relevant to CS regression-production regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-10.34.0 release-10.34.0 Issue or pull request that will be included in release 10.34.0 release-10.35.0 Issue or pull request that will be included in release 10.35.0 release-blocker This bug is blocking the next release team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Jun 9, 2023

Describe the bug

Problem: whenever I am using the function to copy to clipboard any address, I can see how they are actually not copied.

copy-to-clipboard.mp4

Steps to reproduce

  1. Deploy a contract
  2. Interact with the contract
  3. Go to Activity tab
  4. Click on the transaction
  5. Click on the recipient
  6. Click Copy to Clipboard
  7. Paste the value somewhere else -- see how only an empty space is pasted

Error messages or log output

No response

Version

10.31.1 (older issue since a couple of releases at least)

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

@seaona seaona added the type-bug label Jun 9, 2023
@calmacfadden
Copy link

I also experience this issue.

@ryanml
Copy link
Contributor

ryanml commented Jun 27, 2023

So what appears to be happening here in the video is that by the time you're pasting, a blank value has replaced the copied address in the clipboard.

In the hook used to handle clipboard copying, there is a default timeout of 3 seconds: https://github.com/MetaMask/metamask-extension/blob/develop/ui/hooks/useCopyToClipboard.js#L12

After the timeout, two things happen, 1) The clipboard is cleared 2) The copied state is set to false, so the clipboard icon transitions back to its original state.

So, a higher timeout could be passed in here to keep the address copied longer. Maybe others have thoughts on the way to go here. cc: @brad-decker @darkwing

@plasmacorral
Copy link
Contributor

plasmacorral commented Jul 10, 2023

Can be reproduced in v10.33.1 with the public address from wallet view in Chrome 114.0.5735.198 on Mac Ventura 13.4.1.

https://recordit.co/SDH9xytIZr
Copy at 2s, paste at 8s is empty.

@danjm danjm added release-blocker This bug is blocking the next release release-10.34.0 Issue or pull request that will be included in release 10.34.0 regression-production labels Jul 10, 2023
@kevinghim kevinghim added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jul 10, 2023
@darkwing darkwing self-assigned this Jul 11, 2023
@gauthierpetetin gauthierpetetin added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 11, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 12, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 12, 2023
@AlexHerman1 AlexHerman1 added CS-reported issues reported by CS CS-tracking issues being tracked by / relevant to CS labels Jul 14, 2023
@ralphprice
Copy link

I have the same problem. Also, there is no way to display the complete address to do a Ctrl-A Ctrl-C copy.

@VenomNFT
Copy link

Thought I've got crazy ,but I have the same issue now

@EmeraldGuy
Copy link

Why is this still an issues as of 18/07/2023?

@plasmacorral
Copy link
Contributor

We have a change to retain the public address of your selected account in the clipboard for 60 seconds after copying in v10.34 (instead of 3 seconds), which is available to Chrome users now and we hope to have available to Firefox users soon.

We have another change targeted for the v10.35 release which will expand the 60 second timer to any addressed being copied. That release is in test and we anticipate to have it available in the coming weeks.

@katpavan
Copy link

still happening to me

@brianonchain
Copy link

I'm still experiencing the same issue. Also, when you "create a new wallet" using a newly installed MetaMask, the "copy to clipboard" function to copy the 12-word secret recovery phrase also does not work properly.

@lizamae
Copy link

lizamae commented Jul 27, 2023

I recently updated the MM extension to 10.34 via Brave and for a hot minute, the copy/past worked! Then it didn't. Thanks for fixing this you fabulous, brilliant people!!!

@estarossa0
Copy link

Still having this issue on chrome all I am copying is a whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CS-reported issues reported by CS CS-tracking issues being tracked by / relevant to CS regression-production regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-10.34.0 release-10.34.0 Issue or pull request that will be included in release 10.34.0 release-10.35.0 Issue or pull request that will be included in release 10.35.0 release-blocker This bug is blocking the next release team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug
Projects
None yet