Skip to content

Commit

Permalink
cherry-pick: Fix Snaps usage of PhishingController (#27833)
Browse files Browse the repository at this point in the history
## **Description**

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

Fixes two problems with Snaps usage of `PhishingController`. Following
#25839 the
PhishingController expects full URLs instead of hostnames as the input
to `testOrigin`. In that PR, the argument of `isOnPhishingList` was
incorrectly changed. This PR also patches in some changes from the
`snaps` repo that are currently blocked by a release:
MetaMask/snaps#2835,
MetaMask/snaps#2750

This PR cherry-picks a commit from `develop` that fixes this:
1f1e142

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27833?quickstart=1)

## **Manual testing steps**

1. Create a Snap that links to an URL blocked with `eth-phishing-detect`
2. See that triggering the Snap is disallowed if the user has phishing
detection enabled
  • Loading branch information
FrederikBolding authored Oct 15, 2024
1 parent ce5d7d1 commit 6e73681
Show file tree
Hide file tree
Showing 4 changed files with 160 additions and 8 deletions.
Loading

0 comments on commit 6e73681

Please sign in to comment.