Skip to content

Commit

Permalink
chore: urls update for MMI support page (#26839)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates MMI support links to the new page.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
zone-live authored Sep 3, 2024
1 parent 9c24dac commit 5c5bc87
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 27 deletions.
4 changes: 2 additions & 2 deletions builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ buildTypes:
- REQUIRE_SNAPS_ALLOWLIST: true
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.metamask.io/iframe/6.6.2/index.html
- MMI_CONFIGURATION_SERVICE_URL: https://configuration.metamask-institutional.io/v2/configuration/default
- SUPPORT_LINK: https://mmi-support.metamask.io/hc/en-us
- SUPPORT_REQUEST_LINK: https://mmi-support.metamask.io/hc/en-us/requests/new
- SUPPORT_LINK: https://support.metamask-institutional.io
- SUPPORT_REQUEST_LINK: https://support.metamask-institutional.io
- SENTRY_DSN: SENTRY_MMI_DSN
# For some reason, MMI uses this type of versioning
# Leaving it on for backwards compatibility
Expand Down
27 changes: 2 additions & 25 deletions test/e2e/playwright/mmi/specs/navigation.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,8 @@ import {
import { MMIMainMenuPage } from '../pageObjects/mmi-mainMenu-page';
import { MMIMainPage } from '../pageObjects/mmi-main-page';

const portfolio = `${process.env.MMI_E2E_MMI_DASHBOARD_URL}`;
const stake = `${process.env.MMI_E2E_MMI_DASHBOARD_URL}`;
const support = 'https://mmi-support.metamask.io/hc/en-us';
const supportContactUs =
'https://mmi-support.metamask.io/hc/en-us/requests/new';
const support = 'https://support.metamask-institutional.io';
const supportContactUs = 'https://support.metamask-institutional.io';
const mmiHomePage = 'https://metamask.io/institutions/';
const privacyAndNotice = 'https://consensys.io/privacy-notice';
const openSeaTermsOfUse = 'https://opensea.io/securityproviderterms';
Expand Down Expand Up @@ -56,17 +53,6 @@ test.describe('MMI Navigation', () => {
await getPageAndCloseRepeated(context, 'home.html'),
);

// Check main page links
await checkLinkURL(
context,
mainPage.page,
'Portfolio',
portfolio,
'button',
);

await checkLinkURL(context, mainPage.page, 'Stake', stake, 'button');

await checkLinkURL(
context,
mainPage.page,
Expand Down Expand Up @@ -100,15 +86,6 @@ test.describe('MMI Navigation', () => {
'button',
);

await mainMenuPage.openMenu();
await checkLinkURL(
context,
mainMenuPage.page,
'Portfolio Dashboard',
portfolio,
'button',
);

// Check settings links
await mainMenuPage.selectMenuOption('settings');

Expand Down

0 comments on commit 5c5bc87

Please sign in to comment.